progress: Show success message when finished counting down#260
Merged
Conversation
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
Member
|
Verified this is working as expected; $ docker service create --detach=false nginx:alpine
u7rp6ecohz0f3nvygihje5brr
overall progress: 1 out of 1 tasks
1/1: running [==================================================>]
verify: Service converged |
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
==========================================
- Coverage 46.85% 46.83% -0.02%
==========================================
Files 172 172
Lines 11692 11692
==========================================
- Hits 5478 5476 -2
- Misses 5902 5904 +2
Partials 312 312 |
nobiit
pushed a commit
to nobidev/docker-cli
that referenced
this pull request
Nov 19, 2025
[17.10] Fix tests for 17.10 release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids leaving a message on the terminal saying there's 1 second remaining. See #237 (comment).
Open to suggestions on the wording.
cc @thaJeztah