Add shorthand for --tail option#2646
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2646 +/- ##
=======================================
Coverage 58.13% 58.13%
=======================================
Files 295 295
Lines 21194 21194
=======================================
Hits 12321 12321
Misses 7966 7966
Partials 907 907 |
I chose -n shorthand as it's similar with linux `tail` command. Signed-off-by: Александр Менщиков <__Singleton__@hackerdom.ru>
Member
|
Thanks for contributing ; I'm ok with this change (name is consistent with Could you also;
Let me know if you need help with that |
963e16c to
e1a2e16
Compare
Signed-off-by: horpto <__Singleton__@hackerdom.ru>
Contributor
Author
|
@thaJeztah thanks for reply. I found other place with logs. |
albers
approved these changes
Aug 6, 2020
albers
left a comment
Collaborator
There was a problem hiding this comment.
Completion LGTM, thanks for the contribution.
Member
|
@cpuguy83 @silvin-lubecki looking good? |
silvin-lubecki
approved these changes
Aug 10, 2020
silvin-lubecki
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks @horpto 👍
Member
|
Let's get this one merged 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I chose -n shorthand as it's similar with linux
tailcommand.- What I did
- How I did it
- How to verify it
- Description for the changelog
Add shorthand
-nfor --tail option- A picture of a cute animal (not mandatory but encouraged)