Skip to content

Include Microsoft.Common.Test.targets in Arm64 - #9984

Merged
rainersigwald merged 1 commit into
dotnet:mainfrom
dfederm:test-targets-arm64
Apr 15, 2024
Merged

rainersigwald merged 1 commit into
dotnet:mainfrom
dfederm:test-targets-arm64

Conversation

@dfederm

@dfederm dfederm commented Apr 9, 2024 •

Copy link
Copy Markdown
Contributor

This file is missing, leading to errors in the Arm64 flavor of VS

C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\arm64\Microsoft.Common.CurrentVersion.targets
(6824,3): error MSB4019: The imported project "C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bi
n\arm64\Microsoft.Common.Test.targets" was not found. Confirm that the expression in the Import declaration "C:\Program
 Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin\arm64\Microsoft.Common.Test.targets" is correct, and th
at the file exists on disk.

See: https://developercommunity.visualstudio.com/t/Arm64-Unable-to-use-MicrosoftBuildRu/10632924?ref=native&refTime=1712530347328&refUserId=ba1eecbf-9f1b-431b-ba02-0503abd8762c

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Hello @dfederm, I noticed that you’re changing an .swr file or any file under src/Package/MSBuild.VSSetup.. Please make sure to validate this change by an experimental VS insertion. This is accomplished by pushing to an exp/* branch, which requires write permissions to this repo.

@rainersigwald
rainersigwald requested a review from AR-May April 9, 2024 18:58

@rainersigwald rainersigwald left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine and is what I did for other arches in #9547. I think we should consider changing the import to be $(MSBuildToolsPath32) but let's take this for now.

@rainersigwald

Copy link
Copy Markdown
Member

/backport to vs17.10

@github-actions

Copy link
Copy Markdown
Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants