Skip to content

fix(auth): Added EMAIL_EXISTS Auth error message. - #141

Merged
hiranya911 merged 1 commit into
firebase:masterfrom
kcieslinski:master
Feb 3, 2020
Merged

hiranya911 merged 1 commit into
firebase:masterfrom
kcieslinski:master

Conversation

@kcieslinski

@kcieslinski kcieslinski commented Feb 2, 2020 •

Copy link
Copy Markdown
Contributor

Added missing EMAIL_EXISTS Auth error message.
Not sure if the DUPLICATE_EMAIL message is already deprecated, as firebase api documentation is not clear about this for me.

RELEASE NOTE: User management APIs now correctly raise ErrorCode.AlreadyExists when an already in-use email address is specified for a user.

@hiranya911

Copy link
Copy Markdown
Contributor

Thanks @kcieslinski. We need to handle both error codes. See firebase/firebase-admin-python#348 for some more context.

@hiranya911 hiranya911 changed the title Added EMAIL_EXISTS Auth error message. Feb 3, 2020
@hiranya911 hiranya911 self-assigned this Feb 3, 2020

@hiranya911 hiranya911 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hiranya911
hiranya911 merged commit e641899 into firebase:master Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants