remove old SA1019 lint:ignore - #577
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Removes deprecated-API (SA1019) linter suppression comments from protobuf/protoreflect imports (and one inline ignore) now that the repo’s staticcheck target disables SA1019 project-wide, and updates .gitignore for local tooling artifacts.
Changes:
- Removed
//lint:ignore SA1019comments from deprecated protobuf/protoreflect import lines across core package files and tests. - Removed the inline
SA1019ignore aboveproto.MessageTypein the Any fallback resolver. - Added
.claude/to.gitignore.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| invoke.go | Removes SA1019 lint suppression comments from deprecated imports. |
| grpcurl.go | Removes SA1019 lint suppression comments from deprecated imports. |
| grpcurl_test.go | Removes SA1019 lint suppression comments from deprecated imports in tests. |
| format.go | Removes SA1019 lint suppression comments from imports and the inline ignore above proto.MessageType. |
| format_test.go | Removes SA1019 lint suppression comments from deprecated imports in tests. |
| desc_source.go | Removes SA1019 lint suppression comments from deprecated imports. |
| cmd/grpcurl/grpcurl.go | Removes SA1019 lint suppression comment from protoreflect import. |
| .gitignore | Ignores .claude/ local tooling directory. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Comment and gitignore-only changes; deprecated protobuf imports and call sites are unchanged.
Overview
Cleans up deprecated-API linter suppressions now that
staticcheckis run with-checks "inherit,-SA1019", so SA1019 is not reported project-wide.Import lines in
cmd/grpcurl/grpcurl.go,desc_source.go,format.go,grpcurl.go,invoke.go, and their tests lose//lint:ignore SA1019comments ongithub.com/golang/protobuf/*andgithub.com/jhump/protoreflect/*imports.format.goalso drops the inline ignore aboveproto.MessageTypein the Any fallback resolver.Adds
.claude/to.gitignorefor local tooling artifacts. No runtime or API behavior changes—only comments and gitignore.Reviewed by Cursor Bugbot for commit 6e88f15. Bugbot is set up for automated code reviews on this repo. Configure here.