Skip to content

ref(node): Vendor graphql instrumentation#21096

Merged
nicohrubec merged 3 commits into
developfrom
vendor-graphql-instrumentation
May 21, 2026
Merged

ref(node): Vendor graphql instrumentation#21096
nicohrubec merged 3 commits into
developfrom
vendor-graphql-instrumentation

Conversation

@nicohrubec

@nicohrubec nicohrubec commented May 21, 2026

Copy link
Copy Markdown
Member

Vendors @opentelemetry/instrumentation-graphql@0.66.0 into the SDK with no logic changes. Types from the graphql package are inlined as simplified interfaces to avoid requiring the package as a dependency.

Closes #20150

nicohrubec and others added 2 commits May 21, 2026 13:36
Vendors @opentelemetry/instrumentation-graphql@0.66.0 into the SDK with no logic changes. Types from the `graphql` package are inlined as simplified interfaces to avoid requiring the package as a dependency.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
*/

declare class DataLoader<K, V, C = K> {
declare class DataLoader<K, V, _C = K> {

@nicohrubec nicohrubec May 21, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just fixing an unrelated lint warning

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 3f1ec15. Configure here.

Comment thread packages/node/src/integrations/tracing/graphql/vendored/utils.ts
- Source.locationOffset: match upstream type (Location)
- GraphQLUnionType.getTypes(): use ReadonlyArray to match upstream
- Remove unused Location import from instrumentation.ts

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 27.32 kB - -
@sentry/browser - with treeshaking flags 25.74 kB - -
@sentry/browser (incl. Tracing) 45.31 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 47.55 kB - -
@sentry/browser (incl. Tracing, Profiling) 50.3 kB - -
@sentry/browser (incl. Tracing, Replay) 84.92 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 74.43 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 89.64 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 102.24 kB - -
@sentry/browser (incl. Feedback) 44.51 kB - -
@sentry/browser (incl. sendFeedback) 32.13 kB - -
@sentry/browser (incl. FeedbackAsync) 37.25 kB - -
@sentry/browser (incl. Metrics) 28.41 kB - -
@sentry/browser (incl. Logs) 28.64 kB - -
@sentry/browser (incl. Metrics & Logs) 29.33 kB - -
@sentry/react 29.05 kB - -
@sentry/react (incl. Tracing) 47.55 kB - -
@sentry/vue 32.24 kB - -
@sentry/vue (incl. Tracing) 47.17 kB - -
@sentry/svelte 27.35 kB - -
CDN Bundle 29.73 kB - -
CDN Bundle (incl. Tracing) 47.84 kB - -
CDN Bundle (incl. Logs, Metrics) 31.21 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 49.09 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 70.53 kB - -
CDN Bundle (incl. Tracing, Replay) 85.34 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 86.5 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 91.2 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 92.37 kB - -
CDN Bundle - uncompressed 87.8 kB - -
CDN Bundle (incl. Tracing) - uncompressed 144.29 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 92.29 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 148.05 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 217.02 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 263.07 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 266.81 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 276.77 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 280.5 kB - -
@sentry/nextjs (client) 50.03 kB - -
@sentry/sveltekit (client) 45.8 kB - -
@sentry/core/server 76.41 kB - -
@sentry/core/browser 63.16 kB - -
@sentry/node-core 62.59 kB - -
@sentry/node 164.04 kB -0.19% -305 B 🔽
@sentry/node - without tracing 75.02 kB - -
@sentry/aws-serverless 87.24 kB - -
@sentry/cloudflare (withSentry) - minified 173 kB - -
@sentry/cloudflare (withSentry) 432.17 kB - -

View base workflow run

@nicohrubec nicohrubec marked this pull request as ready for review May 21, 2026 12:15
@nicohrubec nicohrubec requested a review from a team as a code owner May 21, 2026 12:15
@nicohrubec nicohrubec requested review from JPeer264, andreiborza and mydea and removed request for a team May 21, 2026 12:15
@nicohrubec nicohrubec merged commit a563b18 into develop May 21, 2026
511 of 516 checks passed
@nicohrubec nicohrubec deleted the vendor-graphql-instrumentation branch May 21, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants