fix: enable and pass HTTPRouteHostnameIntersection conformance test - #511
Open
codebot-robot wants to merge 4 commits into
Open
codebot-robot wants to merge 4 commits into
codebot-robot wants to merge 4 commits into
Conversation
justinsb
approved these changes
Jul 6, 2026
justinsb
previously approved these changes
Jul 6, 2026
Collaborator
|
Please rebase to fix merge conflict /assign @codebot-robot |
Collaborator
|
Looks like we need a go versionbump to address a CVE /assign @codebot-robot |
justinsb
previously approved these changes
Jul 9, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Jul 9, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Jul 9, 2026
Collaborator
|
Please rebase and fix to get the test passing |
Create the conformance test journal detailing test overview, root cause analysis, fix strategy, and validation outcomes. Fixes gke-labs#510
…ection Update the gateway controller to compute parent namespace and hostname intersection matches for each individual listener, so that HTTPRoutes are correctly counted in AttachedRoutes only if they have intersecting hostnames with that specific listener. Fixes gke-labs#510
Uncomment tests.HTTPRouteHostnameIntersection in the e2e conformance test suite to execute and verify the hostname intersection logic during E2E runs. Fixes gke-labs#510
codebot-robot
force-pushed
the
issue_510
branch
from
September 14, 2026 12:37
d692f36 to
f1b309a
Compare
Collaborator
|
ap-e2e is failing: Could be that we need to wait for readiness, could be a kind thing... (maybe OOM or low CPU because the VM is so small?) |
Wait for metallb pods with app=metallb to be ready and retry applying the metallb IPAddressPool and L2Advertisement configuration with a timeout to avoid transient webhook connection refused errors in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the failure in the HTTPRouteHostnameIntersection conformance test.
Changes
pkg/controller/gateway_controller.goto compute both parent namespace match and hostname intersection (usingstate.IntersectHostnames). This ensures that HTTPRoutes are counted inAttachedRoutesfor a listener only if they actually intersect/attach to that specific listener.tests.HTTPRouteHostnameIntersectionintests/e2e/conformance_test.go..agents/skills/implement-conformance-test/journal/httproute-hostname-intersection.mdas per repository guidelines.Fixes #510