Expose s390x CPU Topology to Prometheus#3610
Merged
Merged
Conversation
iwankgb
approved these changes
Oct 26, 2024
Collaborator
|
/ok-to-test |
madeelibm
force-pushed
the
prometheus-s390x-topology
branch
from
9b0e950 to
013c9e9
Compare
Contributor
Author
|
/retest |
madeelibm
force-pushed
the
prometheus-s390x-topology
branch
from
013c9e9 to
3dfc023
Compare
iwankgb
approved these changes
Nov 5, 2024
Collaborator
|
I still can't merge it, I have no idea why |
iwankgb
approved these changes
Feb 20, 2025
Contributor
Author
|
@iwankgb maybe you can rerun tests because it is still saying "Waiting for test status to be reported" |
|
This PR is stale because it has been open 90 days with no activity. This PR will be closed in 30 days unless new comments are made or the stale label is removed. To skip these checks, apply the "lifecycle/frozen" label. |
github-actions
Bot
added
the
lifecycle/stale
Contributor
Author
|
Hi @iwankgb |
Contributor
Author
|
cc: @dims |
Collaborator
|
I'm trying to re-trigger all the necessary builds. |
Collaborator
|
Success! Github moved the button and I missed its new place :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is needed to read CPU topology information from /metrics endpoint.