manager: fix race condition in Stop() using sync.Once#3803
Merged
Conversation
dims
force-pushed
the
fix-destroy-container-race-sync-once
branch
2 times, most recently
from
0702f11 to
84ddcc3
Compare
The switch from RWMutex to sync.Map in commit 20e39fc introduced a race condition in destroyContainer(). When multiple goroutines attempt to destroy the same container simultaneously, they can all call Stop() on the same containerData, causing a "close of closed channel" panic. The panic manifests as: panic: close of closed channel goroutine N [running]: github.com/google/cadvisor/manager.(*containerData).Stop(...) manager/container.go:143 +0x46 Fix this by using sync.Once to ensure the stop channel is only closed once, making Stop() safe to call multiple times. Signed-off-by: Davanum Srinivas <davanum@gmail.com>
dims
force-pushed
the
fix-destroy-container-race-sync-once
branch
from
84ddcc3 to
6bd8d7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The switch from RWMutex to sync.Map in commit 20e39fc introduced a race condition in destroyContainer(). When multiple goroutines attempt to destroy the same container simultaneously, they can all call Stop() on the same containerData, causing a "close of closed channel" panic.
The panic manifests as:
panic: close of closed channel
goroutine N [running]:
github.com/google/cadvisor/manager.(*containerData).Stop(...)
manager/container.go:143 +0x46
Fix this by using sync.Once to ensure the stop channel is only closed once, making Stop() safe to call multiple times.