Skip to content

Add container_creation_time_seconds (previously: container_start_time_seconds); use runtime start time for container_start_time_seconds (podman & docker)#3808

Merged
dims merged 1 commit into
google:masterfrom
ultinous-akos:starttime-fix
Mar 11, 2026
Merged

Conversation

@ultinous-akos

@ultinous-akos ultinous-akos commented Jan 6, 2026

Copy link
Copy Markdown
Contributor

fixes #3688
@iwankgb

iwankgb commented Jan 10, 2026

Copy link
Copy Markdown
Collaborator

Do you mind adding this feature to other handlers too?
@ultinous-akos

ultinous-akos commented Jan 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Do you mind adding this feature to other handlers too?

@iwankgb
For now, i would prefer to keep this PR focused on the Docker and Podman handlers, since that's where I verified the issue and the fix.
@dims

dims commented Jan 14, 2026

Copy link
Copy Markdown
Collaborator

i think at a minimum we'll need containerd too
@dims

dims commented Jan 16, 2026

Copy link
Copy Markdown
Collaborator

we now have a integration test and a way to run it locally as well that covers both docker and containerd metrics - #3819
@ultinous-akos

ultinous-akos commented Jan 23, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @dims
I've added containerd too.
@ultinous-akos

ultinous-akos commented Mar 5, 2026

Copy link
Copy Markdown
Contributor Author

Hello @dims & @iwankgb!

I addressed the requested changes few weeks ago, could you please take another look when you have time, or let me know if anything else is needed? Thanks!
@dims

dims commented Mar 5, 2026

Copy link
Copy Markdown
Collaborator

please squash the commits, i'll then approve the test ci jobs to run
@ultinous-akos
Fix start/creation time metrics in docker, podman and containerd
9c4f1bb 
Add container_creation_time_seconds and keep container_start_time_seconds as runtime start time.

Fixed for:
  - docker
  - podman
  - containerd
@ultinous-akos

ultinous-akos commented Mar 5, 2026

Copy link
Copy Markdown
Contributor Author

Hello @dims,
I've squashed the commits

Thank you!
@eric1tran

eric1tran commented Mar 11, 2026

Copy link
Copy Markdown

Any idea when this might make it into a release version?
@dims dims merged commit 711f2be into google:master Mar 11, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@ultinous-akos @iwankgb @dims @eric1tran