Skip to content

sys/linux: add descriptions for IP tunnels#1907

Merged
morehouse merged 2 commits into
google:masterfrom
chmnchiang:ip_tunnel
Jul 10, 2020
Merged

sys/linux: add descriptions for IP tunnels#1907
morehouse merged 2 commits into
google:masterfrom
chmnchiang:ip_tunnel

Conversation

@chmnchiang

Copy link
Copy Markdown
Contributor

Add descriptions related to IPv4/v6 tunnels (include/uapi/linux/if_tunnel.h, git, bootlin).
It seems like the APIs are not documented in the code, so I looked up their usage in iproute2, see ip/iptunnel.c, ip/ip6tunnel.c, and ip/tunnel.c.
Descriptions of netlink actions are not included in this commit.
Update #533.

@chmnchiang

Copy link
Copy Markdown
Contributor Author
@codecov

codecov Bot commented Jul 7, 2020

Copy link
Copy Markdown

Codecov Report

Merging #1907 into master will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted Files Coverage Δ
prog/any.go 83.7% <0.0%> (ø)
prog/mutation.go 89.5% <0.0%> (+0.2%) ⬆️
prog/checksum.go 89.1% <0.0%> (+2.2%) ⬆️
@chmnchiang chmnchiang requested review from jedav and morehouse July 7, 2020 21:38
Comment thread sys/linux/socket_ip_tunnel.txt Outdated
Comment thread sys/linux/socket_ip_tunnel.txt Outdated
Comment thread sys/linux/socket_ip_tunnel.txt Outdated
@chmnchiang

Copy link
Copy Markdown
Contributor Author

Fixed some problems based on the reviews.
Rebase master to 9f9845e.

Comment thread sys/linux/socket_ip_tunnel.txt Outdated
Comment thread sys/linux/socket_ip_tunnel.txt Outdated
Comment thread sys/linux/socket_ip_tunnel.txt Outdated
Comment thread sys/linux/socket_ip_tunnel.txt Outdated
Comment thread sys/linux/socket_ip_tunnel.txt Outdated
Comment thread sys/linux/socket_ip_tunnel.txt Outdated
Comment thread sys/linux/socket_ip_tunnel.txt Outdated
Comment thread sys/linux/socket_ip_tunnel.txt Outdated
Comment thread sys/linux/socket_ip_tunnel.txt Outdated
Cheng-Min Chiang added 2 commits July 9, 2020 11:37
Add Cheng-Min Chiang (me) to the contributors list.
Add descriptions related to IPv4/v6 tunnels
(include/uapi/linux/if_tunnel.h).
Descriptions of netlink actions are not included in this commit.
Update google#533.
@chmnchiang

Copy link
Copy Markdown
Contributor Author

Rebase master to fd3bba5.
Fix the problems mentioned above.

@jedav jedav left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@morehouse morehouse merged commit 18d18b5 into google:master Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants