Skip to content

Firestore: test document update w/ integer ids#5895

Merged
tseaver merged 5 commits into
masterfrom
5489-firestore-document_set_integer_ids
Sep 20, 2018
Merged

Firestore: test document update w/ integer ids#5895
tseaver merged 5 commits into
masterfrom
5489-firestore-document_set_integer_ids

Conversation

@tseaver

@tseaver tseaver commented Sep 6, 2018

Copy link
Copy Markdown
Contributor

Attempt to reproduce #5489.

@tseaver tseaver added the api: firestore Issues related to the Firestore API. label Sep 6, 2018
@tseaver tseaver requested a review from theacodes September 6, 2018 20:29
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 6, 2018
The new system tests both pass.
@tseaver tseaver force-pushed the 5489-firestore-document_set_integer_ids branch from c1da96e to 9dc2514 Compare September 6, 2018 20:41
@tseaver

tseaver commented Sep 17, 2018

Copy link
Copy Markdown
Contributor Author

@theacodes I'd like to go ahead and merge the new tests: I already closed #5489 as invalid.

@mcdonc mcdonc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tseaver tseaver merged commit e551423 into master Sep 20, 2018
@tseaver tseaver deleted the 5489-firestore-document_set_integer_ids branch September 20, 2018 20:22
tseaver added a commit that referenced this pull request Sep 21, 2018
parthea pushed a commit that referenced this pull request Nov 24, 2025
Attempt to reproduce issue #5489: the new system tests both pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement.

3 participants