Skip to content

Firestore: block calling 'DocumentRef.get()' with a single string.#6270

Merged
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:6203-firestore-documentref_get_no_string
Oct 18, 2018
Merged

Firestore: block calling 'DocumentRef.get()' with a single string.#6270
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:6203-firestore-documentref_get_no_string

Conversation

@tseaver

@tseaver tseaver commented Oct 18, 2018

Copy link
Copy Markdown
Contributor

Closes #6203.
@tseaver tseaver added the api: firestore Issues related to the Firestore API. label Oct 18, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 18, 2018
chrisrossi
chrisrossi approved these changes Oct 18, 2018
View reviewed changes

@chrisrossi chrisrossi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@tseaver tseaver merged commit 65eec54 into googleapis:master Oct 18, 2018
@tseaver tseaver deleted the 6203-firestore-documentref_get_no_string branch October 18, 2018 20:55
parthea pushed a commit that referenced this pull request Nov 24, 2025
@tseaver
Block calling 'DocumentRef.get()' with a single string. (#6270)
f1123cf 
Closes #6203.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement.

3 participants

@tseaver @chrisrossi @googlebot