Skip to content

add templating to asset synth.py#6606

Merged
crwilcox merged 4 commits into
googleapis:masterfrom
crwilcox:templates-asset
Nov 20, 2018
Merged

add templating to asset synth.py#6606
crwilcox merged 4 commits into
googleapis:masterfrom
crwilcox:templates-asset

Conversation

@crwilcox

Copy link
Copy Markdown
Contributor

No description provided.

@crwilcox crwilcox requested a review from busunkim96 November 20, 2018 22:36
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 20, 2018
@busunkim96

Copy link
Copy Markdown
Contributor

It looks like flake and black are in disagreement over some things.

@busunkim96

Copy link
Copy Markdown
Contributor

We could reference Black's .flake8 configuration and update the template's .flake8 to match: https://github.com/ambv/black/blob/master/.flake8

@crwilcox

Copy link
Copy Markdown
Contributor Author

I think the issue is I didn't commit .flake8. Adding now.

@crwilcox crwilcox merged commit 295457a into googleapis:master Nov 20, 2018
Comment thread asset/noxfile.py

# Install all test dependencies, then install this package into the
# virtualenv's dist-packages.
session.install("mock", "pytest")

This comment was marked as spam.

parthea pushed a commit that referenced this pull request Oct 21, 2023
* add templating to asset synth.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

4 participants