Add args from RowIterator.to_dataframe() to QueryJob.to_dataframe()#7241
Merged
Conversation
googlebot
added
the
cla: yes
tseaver
suggested changes
Jan 31, 2019
tseaver
left a comment
tseaver
left a comment
Contributor
There was a problem hiding this comment.
Needs a new test in 'tests/unit/test_job.py' which exercises passing explicit values for the new arguments.
shollyman
reviewed
Jan 31, 2019
shollyman
left a comment
shollyman
left a comment
Contributor
There was a problem hiding this comment.
Per the test failures related to DDL, looks like you need to add the signature change to _EmptyRowIterator as well.
tswast
force-pushed
the
bq-to-dataframe
branch
from
aaf32ce to
276d08d
Compare
Contributor
Author
Added in latest commit. Also added a unit test for the case of an empty iterator to catch the error caught in system tests in the unit tests. |
shollyman
approved these changes
Feb 1, 2019
shollyman
left a comment
shollyman
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the additional tests!
tseaver
approved these changes
Feb 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.