Skip to content

Firestore: add 'v1' fork.#7494

Merged
crwilcox merged 7 commits into
googleapis:masterfrom
tseaver:firestore-add_v1_fork
Mar 28, 2019
Merged

Firestore: add 'v1' fork.#7494
crwilcox merged 7 commits into
googleapis:masterfrom
tseaver:firestore-add_v1_fork

Conversation

@tseaver

@tseaver tseaver commented Mar 6, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@tseaver tseaver added the api: firestore Issues related to the Firestore API. label Mar 6, 2019
@tseaver tseaver requested a review from crwilcox March 6, 2019 20:43
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 6, 2019
@tseaver

tseaver commented Mar 6, 2019

Copy link
Copy Markdown
Contributor Author

The listen system tests are failing with the following error code:

 400 Missing required http header 'google-cloud-resource-prefix' or query param 'database'.

I have asked for clarification about docs for the new requirement.
@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 6, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Mar 13, 2019
@tseaver tseaver removed 🚨 This issue needs some love. do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Mar 27, 2019
@tseaver

tseaver commented Mar 27, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@crwilcox I have rebased against current master, updated to match the rpc_metadata -> metadata change, and applied the same changes to the firestore_v1 tree. System tests pass locally, modulo the known-flaky test_watch_collection (#7130). PTAL.
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Mar 27, 2019
@crwilcox crwilcox merged commit 8942439 into googleapis:master Mar 28, 2019
parthea pushed a commit that referenced this pull request Nov 24, 2025
@tseaver @crwilcox
Firestore: Add v1 API version. (#7494)
d8f437e 
* Update synth to generate 'v1' GAPIC libs.

* Use explicitly-versioned module in examples.

* Use versioned file for test protos in 'v1beta1' test runner.

* Fork manual 'v1beta1' code -> 'v1' and bash to fit.

* Use 'v1' rather than 'v1beta1' in unversioned wrapper.

* Re-run synth to pick up proto changes.

* Accomodate / apply changes for Bidi RPC metadata.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.

4 participants

@tseaver @crwilcox @googlebot @yoshi-automation