Ignore dns_config changes for Autopilot clusters - #15549
Merged
modular-magician merged 1 commit intoAug 17, 2023
Merged
modular-magician merged 1 commit into
modular-magician merged 1 commit into
Conversation
Autopilot does not allow to modify dns_config.
Recently, in Autopilot the default dns_config has changed to be:
```
dns_config {
cluster_dns = "CLOUD_DNS"
cluster_dns_domain = "cluster.local"
cluster_dns_scope = "CLUSTER_SCOPE"
}
```
This breaks Autopilot customers as the terraform tries to converge dns_config back to null.
Signed-off-by: Modular Magician <magic-modules@google.com>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
modular-magician
deleted the
downstream-pr-06fa78a2fa5e5282c6b5c9fe2e23058b6914d624
branch
November 17, 2024 00:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently, GKE Autopilot has changed the default dns_config to be:
Customers are not allowed to modify dns_confg in GKE Autopilot. It's a pre-configured feature/config.
But this change still affects Autopilot customers as the terraform tries to converge back to dns_config=null (original default value).
To fix this and to be aligned with the fact that it's not allowed to modify dns_config in Autopilot, this PR makes
google_container_clusterto ignoredns_configchanges.Issues:
Fixes #15484
Fixes #15454
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#8654