feat: add topologySpreadConstraints support to helm chart#1041
feat: add topologySpreadConstraints support to helm chart#1041kimsehwan96 wants to merge 2 commits into
Conversation
✅ Deploy Preview for agent-sandbox canceled.
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kimsehwan96 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @kimsehwan96! |
|
Hi @kimsehwan96. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughHelm chart adds a controller ChangesHelm topology spread constraints
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds Helm chart support for configuring topologySpreadConstraints on the controller Deployment PodSpec, enabling operators to spread controller replicas across topology domains (e.g., nodes/zones) for improved availability when replicaCount > 1, while keeping behavior unchanged when the value is unset/empty.
Changes:
- Add a new
topologySpreadConstraintsvalue tovalues.yaml(default[]). - Render
spec.template.spec.topologySpreadConstraintsin the controller Deployment only when provided. - Document the new value in the chart README parameter table.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| helm/values.yaml | Introduces topologySpreadConstraints with inline examples/comments. |
| helm/templates/deployment.yaml | Conditionally renders topologySpreadConstraints into the controller PodSpec. |
| helm/README.md | Adds the new value to the chart configuration table. |
|
/lgtm |
|
New changes are detected. LGTM label has been removed. |
Signed-off-by: kimsehwan96 <sktpghks138@gmail.com>
c1e8be1 to
1bc513c
Compare
What this PR does / why we need it:
Adds an optional
topologySpreadConstraintsvalue to the controller Deployment, rendered only when set. Lets operators spread controller replicas across nodes/zones for availability when running with replicaCount > 1.Mirrors the existing affinity/nodeSelector/tolerations pattern; no behavior change when unset.
Which issue(s) this PR is related to:
Release Note
Summary by CodeRabbit
topologySpreadConstraints, default[]) to control how pods are distributed across topology domains.topologySpreadConstraintsparameter and an example.