Skip to content

add example on aio-sandbox#152

Merged
k8s-ci-robot merged 5 commits into
kubernetes-sigs:mainfrom
lizzzcai:add-aio-sandbox-example
Nov 25, 2025
Merged

add example on aio-sandbox#152
k8s-ci-robot merged 5 commits into
kubernetes-sigs:mainfrom
lizzzcai:add-aio-sandbox-example

Conversation

@lizzzcai

Copy link
Copy Markdown
Contributor

add an example on how to run aio-sandbox via agent-sandbox.

@netlify

netlify Bot commented Nov 12, 2025

Copy link
Copy Markdown

Deploy Preview for agent-sandbox canceled.

Name Link
🔨 Latest commit 3309cd0
🔍 Latest deploy log https://app.netlify.com/projects/agent-sandbox/deploys/69251859f4986200087adbda
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 12, 2025
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Welcome @lizzzcai!

It looks like this is your first PR to kubernetes-sigs/agent-sandbox 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/agent-sandbox has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @lizzzcai. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 12, 2025

@barney-s barney-s left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds a great example for the aio-sandbox. It effectively showcases the core functionalities of the agent-sandbox.
I've added several comments with suggestions to enhance the example's robustness, clarity, and documentation. Please review and address them.

Comment thread examples/aio-sandbox/aio-sandbox.yaml
Comment thread examples/aio-sandbox/README.md
Comment thread examples/aio-sandbox/main.py Outdated
Comment thread examples/aio-sandbox/site_to_markdown.py Outdated
Comment thread examples/aio-sandbox/site_to_markdown.py Outdated
Comment thread examples/aio-sandbox/README.md
Comment thread examples/aio-sandbox/aio-sandbox.yaml
Comment thread examples/aio-sandbox/main.py
Comment thread examples/aio-sandbox/base/kustomization.yaml Outdated
Comment thread examples/aio-sandbox/site_to_markdown.py Outdated
@barney-s

Copy link
Copy Markdown
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 12, 2025
@lizzzcai

Copy link
Copy Markdown
Contributor Author

Hi @barney-s , thanks for your review. I updated the PR to address most of your comments, can you help to take a look again, thanks.

Comment thread examples/aio-sandbox/aio-sandbox.yaml Outdated
@ycjcl868 ycjcl868 mentioned this pull request Nov 14, 2025
Comment thread examples/aio-sandbox/aio-sandbox.yaml Outdated

@ycjcl868 ycjcl868 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread examples/aio-sandbox/aio-sandbox.yaml Outdated
Comment thread examples/aio-sandbox/aio-sandbox.yaml Outdated
@lizzzcai lizzzcai requested a review from barney-s November 18, 2025 14:14
Comment thread examples/aio-sandbox/README.md Outdated
Comment thread examples/aio-sandbox/README.md Outdated
@lizzzcai lizzzcai requested a review from janetkuo November 25, 2025 01:21
Signed-off-by: Lize Cai <lize.cai@sap.com>
Signed-off-by: Lize Cai <lize.cai@sap.com>
Signed-off-by: Lize Cai <lize.cai@sap.com>
Signed-off-by: Lize Cai <lize.cai@sap.com>
@lizzzcai lizzzcai force-pushed the add-aio-sandbox-example branch from bacb2f1 to f42b531 Compare November 25, 2025 01:32
Comment thread examples/aio-sandbox/README.md
Comment thread examples/aio-sandbox/README.md
…-client.

Signed-off-by: Lize Cai <lize.cai@sap.com>

@janetkuo janetkuo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2025
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janetkuo, lizzzcai, ycjcl868

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1859a3c into kubernetes-sigs:main Nov 25, 2025
9 of 10 checks passed
@lizzzcai lizzzcai deleted the add-aio-sandbox-example branch November 26, 2025 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

5 participants