fix: add pvc annotations/labels from volume claim tpl by dhenkel92 · Pull Request #217 · kubernetes-sigs/agent-sandbox

dhenkel92 · 2025-12-17T08:55:20Z

The Sandbox CRD lets you define volume claim templates, including metadata like labels and annotations. However, these aren’t synced to the generated PVC, so this PR fills that gap.

netlify · 2025-12-17T08:55:26Z

✅ Deploy Preview for agent-sandbox ready!

Name	Link
🔨 Latest commit	`ed8b8e7`
🔍 Latest deploy log	https://app.netlify.com/projects/agent-sandbox/deploys/69c52b98e48f7800088283c7
😎 Deploy Preview	https://deploy-preview-217--agent-sandbox.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

k8s-ci-robot · 2025-12-17T08:55:29Z

Welcome @dhenkel92!

It looks like this is your first PR to kubernetes-sigs/agent-sandbox 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/agent-sandbox has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2025-12-17T08:55:30Z

Hi @dhenkel92. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

janetkuo · 2025-12-17T17:47:04Z

/ok-to-test

barney-s

The changes look good and correctly solve the problem described. The usage of maps.Clone is appropriate and safe. I have a minor suggestion regarding the consistency of labels on the generated PVCs compared to other resources.

janetkuo · 2025-12-19T22:01:54Z


+		pvcLabels := map[string]string{
+			sandboxLabel: nameHash,
+		}


Move this part to after maps.Copy, to prevent users from overwriting system-managed labels.

dhenkel92 · 2026-01-19T12:15:22Z

@janetkuo could you please take another look at this PR?

k8s-triage-robot · 2026-03-18T12:08:18Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 30d of inactivity, lifecycle/stale is applied
After 15d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to us at Agent Sandbox.

/lifecycle stale

dhenkel92 · 2026-03-18T13:54:43Z

/remove-lifecycle stale

k8s-ci-robot · 2026-03-19T19:09:30Z

@dhenkel92: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
presubmit-agent-sandbox-lint-api	`83a995b`	link	true	`/test presubmit-agent-sandbox-lint-api`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

dhenkel92 · 2026-03-26T19:59:57Z

/retest

aditya-shantanu · 2026-04-02T22:16:08Z

/lgtm
/approve

barney-s · 2026-04-02T22:48:44Z

/lgtm
/approve

k8s-ci-robot · 2026-04-02T22:48:53Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aditya-shantanu, barney-s, dhenkel92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [barney-s]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot requested review from janetkuo and soltysh December 17, 2025 08:55

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 17, 2025

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 17, 2025

dhenkel92 force-pushed the dhenkel/12-11-fix_add_pvc_annotations_labels_from_pvc_tpl branch from 57b128b to 00fdb06 Compare December 17, 2025 08:59

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 17, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 17, 2025

janetkuo reviewed Dec 17, 2025

View reviewed changes

Comment thread controllers/sandbox_controller.go Outdated

dhenkel92 force-pushed the dhenkel/12-11-fix_add_pvc_annotations_labels_from_pvc_tpl branch from 00fdb06 to 20cfdf4 Compare December 18, 2025 11:20

barney-s reviewed Dec 18, 2025

View reviewed changes

Comment thread controllers/sandbox_controller.go Outdated

dhenkel92 force-pushed the dhenkel/12-11-fix_add_pvc_annotations_labels_from_pvc_tpl branch from 20cfdf4 to 5c444ca Compare December 19, 2025 09:44

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 19, 2025

janetkuo reviewed Dec 19, 2025

View reviewed changes

dhenkel92 force-pushed the dhenkel/12-11-fix_add_pvc_annotations_labels_from_pvc_tpl branch from 5c444ca to 83a995b Compare January 5, 2026 07:29

dhenkel92 requested review from barney-s and janetkuo January 19, 2026 13:19

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 18, 2026

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 18, 2026

fix: add pvc annotations/labels from pvc tpl

ed8b8e7

dhenkel92 force-pushed the dhenkel/12-11-fix_add_pvc_annotations_labels_from_pvc_tpl branch from 83a995b to ed8b8e7 Compare March 26, 2026 12:50

k8s-ci-robot assigned aditya-shantanu Apr 2, 2026

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 2, 2026

k8s-ci-robot assigned barney-s Apr 2, 2026

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2026

k8s-ci-robot merged commit 2bb2463 into kubernetes-sigs:main Apr 2, 2026
10 checks passed

This was referenced Apr 3, 2026

N?A #513

Closed

Rebase fork onto latest upstream clouddatalabs/agent-sandbox#2

Merged

github-actions Bot mentioned this pull request Apr 6, 2026

Pull requests report (5/04/2026 17:47) #524

Closed

github-actions Bot mentioned this pull request Apr 13, 2026

Pull requests report (12/04/2026 17:50) #580

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: add pvc annotations/labels from volume claim tpl#217

fix: add pvc annotations/labels from volume claim tpl#217
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
DataDog:dhenkel/12-11-fix_add_pvc_annotations_labels_from_pvc_tpl

dhenkel92 commented Dec 17, 2025

netlify Bot commented Dec 17, 2025 •

edited

Loading

k8s-ci-robot commented Dec 17, 2025

k8s-ci-robot commented Dec 17, 2025

janetkuo commented Dec 17, 2025

Uh oh!

barney-s left a comment

Uh oh!

janetkuo Dec 19, 2025

dhenkel92 Jan 5, 2026

dhenkel92 commented Jan 19, 2026

k8s-triage-robot commented Mar 18, 2026

dhenkel92 commented Mar 18, 2026

k8s-ci-robot commented Mar 19, 2026

dhenkel92 commented Mar 26, 2026

aditya-shantanu commented Apr 2, 2026

barney-s commented Apr 2, 2026

k8s-ci-robot commented Apr 2, 2026

Uh oh!

Labels

6 participants

Uh oh!

Conversation

dhenkel92 commented Dec 17, 2025

netlify Bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for agent-sandbox ready!

k8s-ci-robot commented Dec 17, 2025

k8s-ci-robot commented Dec 17, 2025

janetkuo commented Dec 17, 2025

Uh oh!

barney-s left a comment

Choose a reason for hiding this comment

Uh oh!

janetkuo Dec 19, 2025

Choose a reason for hiding this comment

dhenkel92 Jan 5, 2026

Choose a reason for hiding this comment

dhenkel92 commented Jan 19, 2026

k8s-triage-robot commented Mar 18, 2026

dhenkel92 commented Mar 18, 2026

k8s-ci-robot commented Mar 19, 2026

dhenkel92 commented Mar 26, 2026

aditya-shantanu commented Apr 2, 2026

barney-s commented Apr 2, 2026

k8s-ci-robot commented Apr 2, 2026

Uh oh!

Labels

6 participants

netlify Bot commented Dec 17, 2025 •

edited

Loading