Generate native k8s clients#233
Conversation
✅ Deploy Preview for agent-sandbox canceled.
|
|
Welcome @mastersingh24! |
|
Hi @mastersingh24. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Let me know if we should add an example of how to use this or a quick e2e smoke test |
|
thx for submitting this @mastersingh24 . Can you provide an example of how you'd use this? |
|
/ok-to-test |
bf17028 to
48b5f05
Compare
|
/retest |
|
@justinsb - could you take a look at this one? |
janetkuo
left a comment
There was a problem hiding this comment.
Thanks for the PR! To make this easier to review and keep our history clean, could you please split this into two commits? One for the manual setup (scripts and manual additions) and a second for the generated code.
48b5f05 to
b1f8813
Compare
b1f8813 to
1a93eb6
Compare
93c01ff to
118125f
Compare
Done! |
yongruilin
left a comment
There was a problem hiding this comment.
I think the commit message needs to be align with the change (boilerplate.go.txt is gone).
Anything else that is blocking from merging this PR? It would be quite useful for other project to do agent-sandbox integration with this change.
janetkuo
left a comment
There was a problem hiding this comment.
Thanks, this looks good.
Just need to fix the year and update commit message as @yongruilin suggested.
/approve
Add script to generate native Kubernetes clients for Sandbox and Extensions APIs. This includes configuration and scripts for agents.x-k8s.io and extensions.agents.x-k8s.io. Changes include: - Added dev/tools/client-gen-go.sh to invoke client-gen, listers-gen, and informer-gen. - Added //go:generate directive to codegen.go for easy regeneration. - Configured api/v1alpha1 and extensions/api/v1alpha1 with doc.go and groupversion_info.go helpers (SchemeGroupVersion, Resource). - Annotated API types with +genclient.
Generate and add the native Go client a
118125f to
f1e1e74
Compare
Done! Good find! |
janetkuo
left a comment
There was a problem hiding this comment.
/lgtm
Thanks a lot for the change!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: janetkuo, mastersingh24 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Generate native Kubernetes clients for Sandbox and Extensions APIs. This includes configuration and scripts for agents.x-k8s.io and extensions.agents.x-k8s.io.
Changes include: