Skip to content

Fix/configurable router timeout#374

Merged
k8s-ci-robot merged 5 commits into
kubernetes-sigs:mainfrom
shreyas-badiger:fix/configurable-router-timeout
Mar 12, 2026
Merged

Fix/configurable router timeout#374
k8s-ci-robot merged 5 commits into
kubernetes-sigs:mainfrom
shreyas-badiger:fix/configurable-router-timeout

Conversation

@shreyas-badiger

@shreyas-badiger shreyas-badiger commented Mar 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #369

We also hit the same issue while testing the agent-sandbox with MCP.

The connections are timing out at the sandbox-router.

What this PR includes:

  • Make the sandbox-router timeout configurable through a ENV variable.
  • Update the sandbox-router doc with configuration details for PROXY_TIMEOUT_SECONDS
  • sandbox-router is missing a test file. Added some unit tests.
  • update dev/tools/test-unit to run python tests as part of the CI.
@netlify

netlify Bot commented Mar 7, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for agent-sandbox canceled.

Name Link
🔨 Latest commit c5d4ae9
🔍 Latest deploy log https://app.netlify.com/projects/agent-sandbox/deploys/69b1d5e4a8e37f0008b244e0
@k8s-ci-robot k8s-ci-robot requested review from barney-s and igooch March 7, 2026 16:10
@linux-foundation-easycla

linux-foundation-easycla Bot commented Mar 7, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA Signed

The committers listed above are authorized under a signed CLA.
@k8s-ci-robot

k8s-ci-robot commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

Welcome @shreyas-badiger!

It looks like this is your first PR to kubernetes-sigs/agent-sandbox 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/agent-sandbox has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃
@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 7, 2026
@k8s-ci-robot

k8s-ci-robot commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

Hi @shreyas-badiger. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 7, 2026
@janetkuo janetkuo added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 10, 2026
janetkuo
janetkuo reviewed Mar 10, 2026
View reviewed changes
Comment thread clients/python/agentic-sandbox-client/sandbox-router/test_sandbox_router.py Outdated
Comment thread clients/python/agentic-sandbox-client/sandbox-router/test_sandbox_router.py
igooch
igooch reviewed Mar 10, 2026
View reviewed changes

@igooch igooch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, overall looks good.
Comment thread clients/python/agentic-sandbox-client/sandbox-router/sandbox_router.py Outdated
Comment thread clients/python/agentic-sandbox-client/sandbox-router/test_sandbox_router.py
@noeljackson noeljackson mentioned this pull request Mar 11, 2026
Closed
@shreyas-badiger

shreyas-badiger commented Mar 11, 2026

Copy link
Copy Markdown
Contributor Author

A few comments, overall looks good.

Hello. I have addressed the comments, ptal.
janetkuo
janetkuo approved these changes Mar 12, 2026
View reviewed changes

@janetkuo janetkuo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2026
@k8s-ci-robot

k8s-ci-robot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janetkuo, shreyas-badiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2026
@k8s-ci-robot k8s-ci-robot merged commit 49919f0 into kubernetes-sigs:main Mar 12, 2026
9 checks passed
SHRUTI6991 pushed a commit to SHRUTI6991/agent-sandbox-initial-playing that referenced this pull request Mar 12, 2026
@shreyas-badiger @SHRUTI6991
Fix/configurable router timeout (kubernetes-sigs#374)
888b2be 
* make router-timeout configurable

* add unit tests

* update readme

* error handling for PROXY_TIMEOUT_SECONDS

* run python tests as part of the CI
chw120 pushed a commit to chw120/agent-sandbox that referenced this pull request Mar 13, 2026
@shreyas-badiger @chw120
Fix/configurable router timeout (kubernetes-sigs#374)
7856326 
* make router-timeout configurable

* add unit tests

* update readme

* error handling for PROXY_TIMEOUT_SECONDS

* run python tests as part of the CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

4 participants

@shreyas-badiger @k8s-ci-robot @janetkuo @igooch