Skip to content

Concurrency tests: Turn up concurrency on the controllers and do E2E tests.#398

Merged
k8s-ci-robot merged 3 commits into
kubernetes-sigs:mainfrom
aditya-shantanu:concurrency-tests
Mar 18, 2026
Merged

Concurrency tests: Turn up concurrency on the controllers and do E2E tests.#398
k8s-ci-robot merged 3 commits into
kubernetes-sigs:mainfrom
aditya-shantanu:concurrency-tests

Conversation

@aditya-shantanu

@aditya-shantanu aditya-shantanu commented Mar 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR tests following scenarios with concurrency turned on:

  1. Creating sandboxes.
  2. Creating sandbox claims with enough sandboxes in warmpool
  3. Creating sandbox claims with not enough sandboxes in warmpool
@k8s-ci-robot

k8s-ci-robot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2026
@netlify

netlify Bot commented Mar 11, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for agent-sandbox ready!

Name Link
🔨 Latest commit 8accc65
🔍 Latest deploy log https://app.netlify.com/projects/agent-sandbox/deploys/69b9afd73d47180008f5d29e
😎 Deploy Preview https://deploy-preview-398--agent-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 11, 2026
@aditya-shantanu

aditya-shantanu commented Mar 11, 2026

Copy link
Copy Markdown
Collaborator Author

/ok-to-test
@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 11, 2026
@aditya-shantanu

aditya-shantanu commented Mar 11, 2026

Copy link
Copy Markdown
Collaborator Author

/retest
@aditya-shantanu aditya-shantanu marked this pull request as ready for review March 11, 2026 22:47
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2026
@k8s-ci-robot k8s-ci-robot requested a review from justinsb March 11, 2026 22:48
vicentefb
vicentefb reviewed Mar 12, 2026
View reviewed changes
Comment thread test/e2e/parallelism_test.go Outdated
vicentefb
vicentefb reviewed Mar 12, 2026
View reviewed changes
Comment thread test/e2e/parallelism_test.go
vicentefb
vicentefb reviewed Mar 12, 2026
View reviewed changes
Comment thread test/e2e/parallelism_test.go Outdated
vicentefb
vicentefb reviewed Mar 12, 2026
View reviewed changes
Comment thread test/e2e/parallelism_test.go
janetkuo
janetkuo reviewed Mar 13, 2026
View reviewed changes
Comment thread test/e2e/parallelism_test.go Outdated
Comment thread test/e2e/parallelism_test.go
Comment thread test/e2e/parallelism_test.go Outdated
Comment thread test/e2e/parallelism_test.go
vicentefb
vicentefb reviewed Mar 16, 2026
View reviewed changes
Comment thread test/e2e/parallelism_test.go
vicentefb
vicentefb approved these changes Mar 18, 2026
View reviewed changes

@vicentefb vicentefb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2026
@k8s-ci-robot

k8s-ci-robot commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aditya-shantanu, vicentefb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2026
@vicentefb

vicentefb commented Mar 18, 2026

Copy link
Copy Markdown
Member

/assign @janetkuo
@k8s-ci-robot k8s-ci-robot merged commit 98453f0 into kubernetes-sigs:main Mar 18, 2026
10 checks passed
@aditya-shantanu aditya-shantanu deleted the concurrency-tests branch March 20, 2026 02:15
nadolskit pushed a commit to nadolskit/agent-sandbox that referenced this pull request Mar 20, 2026
@aditya-shantanu @nadolskit
Concurrency tests: Turn up concurrency on the controllers and do E2E …
5c82c7c 
…tests. (kubernetes-sigs#398)

* add concurrency tests

* fix test failure

* pr feedback
@github-actions github-actions Bot mentioned this pull request Apr 6, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

4 participants

@aditya-shantanu @k8s-ci-robot @vicentefb @janetkuo