Skip to content

feat|fix: add fix-gomod presubmit to verify go modules are tidy#442

Merged
k8s-ci-robot merged 3 commits into
kubernetes-sigs:mainfrom
yongruilin:fix-gomod-presubmit
Mar 20, 2026
Merged

feat|fix: add fix-gomod presubmit to verify go modules are tidy#442
k8s-ci-robot merged 3 commits into
kubernetes-sigs:mainfrom
yongruilin:fix-gomod-presubmit

Conversation

@yongruilin

Copy link
Copy Markdown
Contributor
  • Adds dev/tools/fix-gomod shell script that runs go mod tidy across all Go modules in the repo
  • Fixes currently stale go.mod/go.sum in root, dev/tools, and site modules
  • Improves test-autogen-up-to-date logging to clearly show which fix-* script is running

The script follows the fix-* naming convention, so the existing presubmit-test-autogen-up-to-date Prow job automatically picks it up — no CI config changes needed. That job globs all dev/tools/fix-* scripts, runs each one, and fails if any produce a git diff.

@netlify

netlify Bot commented Mar 20, 2026

Copy link
Copy Markdown

Deploy Preview for agent-sandbox canceled.

Name Link
🔨 Latest commit 5611780
🔍 Latest deploy log https://app.netlify.com/projects/agent-sandbox/deploys/69bcdf55bcd45d00084b7f0e
@k8s-ci-robot k8s-ci-robot requested review from barney-s and igooch March 20, 2026 05:35
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 20, 2026
Adds a Python script that runs `go mod tidy` across all Go modules in
the repo. Since it follows the `fix-*` naming convention, it is
automatically picked up by the existing test-autogen-up-to-date
presubmit.
Cleans up stale entries in go.mod and go.sum for the root and
dev/tools modules.
@codebot-robot

Copy link
Copy Markdown

Overseer agent is monitoring this PR.

@codebot-robot

Copy link
Copy Markdown

/label overseer

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

@codebot-robot: The label(s) /label overseer cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor, ci-short, ci-extended, ci-full. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

/label overseer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codebot-robot

Copy link
Copy Markdown

/assign @codebot-robot

@barney-s

Copy link
Copy Markdown
Collaborator

/lgtm

thanks for doing this

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2026
@barney-s

Copy link
Copy Markdown
Collaborator

/approve

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barney-s, yongruilin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2026
@k8s-ci-robot k8s-ci-robot merged commit 5330e86 into kubernetes-sigs:main Mar 20, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

4 participants