Skip to content

Use gvisor in openclaw example#475

Merged
k8s-ci-robot merged 8 commits into
kubernetes-sigs:mainfrom
janetkuo:openclaw-gvisor
May 14, 2026
Merged

Use gvisor in openclaw example#475
k8s-ci-robot merged 8 commits into
kubernetes-sigs:mainfrom
janetkuo:openclaw-gvisor

Conversation

@janetkuo

@janetkuo janetkuo commented Mar 25, 2026

Copy link
Copy Markdown
Member

This is verified on GKE + gVisor runtime class
@netlify

netlify Bot commented Mar 25, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for agent-sandbox canceled.

Name Link
🔨 Latest commit df25ac6
🔍 Latest deploy log https://app.netlify.com/projects/agent-sandbox/deploys/69fbd07c4dc30900088e281b
@k8s-ci-robot k8s-ci-robot requested review from igooch and justinsb March 25, 2026 10:48
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 25, 2026
justinsb
justinsb approved these changes Mar 25, 2026
View reviewed changes

@justinsb justinsb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2026
@janetkuo

janetkuo commented Mar 25, 2026

Copy link
Copy Markdown
Member Author

/hold
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2026
@janetkuo

janetkuo commented Mar 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Enabling gVisor breaks port-forwarding (ref #158, #159). Holding this PR for now
dongjiang1989
dongjiang1989 approved these changes Mar 25, 2026
View reviewed changes

@dongjiang1989 dongjiang1989 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GLTM
@janetkuo janetkuo removed this from Agent Sandbox Apr 29, 2026
@janetkuo janetkuo removed this from Agent Sandbox Apr 29, 2026
@aditya-shantanu

aditya-shantanu commented May 4, 2026

Copy link
Copy Markdown
Collaborator

@janetkuo - you're still working on this PR ?
@janetkuo janetkuo requested a review from Copilot May 6, 2026 22:45
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2026
Copilot AI review requested due to automatic review settings May 6, 2026 23:14
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 6, 2026
Copilot AI reviewed May 6, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comment thread examples/openclaw-sandbox/README.md Outdated
Copilot AI review requested due to automatic review settings May 6, 2026 23:21
Copilot AI reviewed May 6, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Comment thread examples/openclaw-sandbox/README.md Outdated
Comment thread examples/openclaw-sandbox/README.md
@janetkuo janetkuo requested a review from Copilot May 6, 2026 23:32
Copilot AI reviewed May 6, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comment thread examples/openclaw-sandbox/README.md Outdated
@janetkuo

janetkuo commented May 6, 2026

Copy link
Copy Markdown
Member Author

I've addressed #475 (comment)

/unhold
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2026
@janetkuo

janetkuo commented May 7, 2026

Copy link
Copy Markdown
Member Author 
panic: test timed out after 10m0s

Seems unrelated to my change.
/retest
@aditya-shantanu

aditya-shantanu commented May 14, 2026

Copy link
Copy Markdown
Collaborator

/lgtm
/approve
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2026
@k8s-ci-robot

k8s-ci-robot commented May 14, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aditya-shantanu, dongjiang1989, janetkuo, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@k8s-ci-robot k8s-ci-robot merged commit d0c124d into kubernetes-sigs:main May 14, 2026
10 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Agent Sandbox May 14, 2026
khirotaka pushed a commit to khirotaka/agent-sandbox that referenced this pull request Jun 12, 2026
@janetkuo @khirotaka
Use gvisor in openclaw example (kubernetes-sigs#475)
a937070 
* Use gvisor in openclaw example

* docs: address Copilot review comments for openclaw example

* docs: add gVisor port-forward limitation note to README

* docs: use standard markdown bold for gVisor limitation note

* docs: restore GitHub alert syntax for gVisor limitation

* docs: clarify usage steps for gVisor in openclaw example

* docs: address further Copilot comments on openclaw README

* docs: remove trailing whitespace in openclaw README
alexatakvelon pushed a commit to volatilemolotov/agent-sandbox that referenced this pull request Jun 24, 2026
@janetkuo
Use gvisor in openclaw example (kubernetes-sigs#475)
2f4b6d2 
* Use gvisor in openclaw example

* docs: address Copilot review comments for openclaw example

* docs: add gVisor port-forward limitation note to README

* docs: use standard markdown bold for gVisor limitation note

* docs: restore GitHub alert syntax for gVisor limitation

* docs: clarify usage steps for gVisor in openclaw example

* docs: address further Copilot comments on openclaw README

* docs: remove trailing whitespace in openclaw README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ready-for-review size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

6 participants

@janetkuo @aditya-shantanu @k8s-ci-robot @justinsb @dongjiang1989