Skip to content

Add helm chart for agent sandbox#618

Merged
k8s-ci-robot merged 2 commits into
kubernetes-sigs:mainfrom
pandaji:add-helm-chart-for-agent-sandbox
Apr 29, 2026
Merged

Add helm chart for agent sandbox#618
k8s-ci-robot merged 2 commits into
kubernetes-sigs:mainfrom
pandaji:add-helm-chart-for-agent-sandbox

Conversation

@pandaji

@pandaji pandaji commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

For Issue #483

  1. Add a new helm chart
  2. Extract the controller configs and expose through the helm chart
  3. Add codegen output destination to helm template folder
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 18, 2026
@netlify

netlify Bot commented Apr 18, 2026

Copy link
Copy Markdown

Deploy Preview for agent-sandbox ready!

Name Link
🔨 Latest commit 41adc6b
🔍 Latest deploy log https://app.netlify.com/projects/agent-sandbox/deploys/69f15258fcd15800090a724d
😎 Deploy Preview https://deploy-preview-618--agent-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 18, 2026
@k8s-ci-robot k8s-ci-robot requested review from barney-s and igooch April 18, 2026 21:44
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Welcome @pandaji!

It looks like this is your first PR to kubernetes-sigs/agent-sandbox 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/agent-sandbox has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @pandaji. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 18, 2026
@janetkuo janetkuo requested a review from Copilot April 18, 2026 22:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a Helm chart–based installation path for the agent-sandbox controller (and optional extensions), migrating generated CRDs/RBAC into the chart and wiring CI/tools to keep generated assets synchronized.

Changes:

  • Replace legacy static Kubernetes manifests with a Helm chart (templates + values + README).
  • Move controller-gen outputs (CRDs/RBAC) to helm/crds and helm/templates, and update docs accordingly.
  • Add tooling/CI checks to keep generated outputs up-to-date and enforce chart version bumping when generated assets change.

Reviewed changes

Copilot reviewed 22 out of 28 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
k8s/extensions.controller.yaml Removes legacy extensions Deployment manifest.
k8s/controller.yaml Removes legacy core install manifest (namespace/SA/RBAC/service/deploy).
helm/Chart.yaml Introduces Helm chart metadata.
helm/values.yaml Adds chart values for image/controller flags/resources/scheduling and extensions toggle.
helm/README.md Documents Helm install/upgrade/uninstall and values reference.
helm/templates/_helpers.tpl Adds helper templates (labels, namespace, image reference).
helm/templates/_controller-args.generated.tpl Generates controller CLI args from Helm values.
helm/templates/namespace.yaml Optionally creates the target namespace.
helm/templates/serviceaccount.yaml Creates controller ServiceAccount.
helm/templates/service.yaml Exposes metrics Service.
helm/templates/deployment.yaml Deploys controller with probes, args, and resource/scheduling knobs.
helm/templates/rbac.generated.yaml Adds generated core ClusterRole rules for the controller.
helm/templates/clusterrolebinding.yaml Binds core ClusterRole to controller ServiceAccount.
helm/templates/extensions-rbac.generated.yaml Adds generated extensions ClusterRole rules.
helm/templates/clusterrolebinding-extensions.yaml Conditionally binds extensions ClusterRole when extensions are enabled.
helm/crds/agents.x-k8s.io_sandboxes.yaml Packages generated Sandbox CRD for Helm install.
helm/crds/extensions.agents.x-k8s.io_sandboxclaims.yaml Packages generated SandboxClaim CRD for Helm install.
helm/crds/extensions.agents.x-k8s.io_sandboxtemplates.yaml Packages generated SandboxTemplate CRD for Helm install.
helm/crds/extensions.agents.x-k8s.io_sandboxwarmpools.yaml Packages generated SandboxWarmPool CRD for Helm install.
docs/development.md Updates development deployment instructions to use Helm and helm/crds.
docs/configuration.md Reframes configuration docs around Helm values and examples.
README.md Updates top-level install guidance to point to Helm chart README.
codegen.go Redirects controller-gen CRD/RBAC outputs to Helm chart directories.
dev/tools/fix-helm-values Adds generator to sync Helm values/args template from controller flags.
dev/tools/bump-chart-version Adds script to bump chart patch version when generated chart files change.
dev/tools/fix-go-generate Runs go generate then bumps chart version when generated outputs change.
dev/ci/presubmits/test-autogen-up-to-date Adds check ensuring chart version bump accompanies generated Helm asset changes.
.github/workflows/ci.yml Adds verify-generate CI job and broadens path triggers to include Helm/codegen-related paths.
Comment thread helm/templates/_helpers.tpl Outdated
Comment thread helm/README.md Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread dev/ci/presubmits/test-autogen-up-to-date Outdated
Comment thread dev/tools/fix-go-generate Outdated
@pandaji pandaji changed the title Add helm chart for agent sandbox Apr 18, 2026
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2026
@pandaji pandaji force-pushed the add-helm-chart-for-agent-sandbox branch from 00bbf5d to e293a91 Compare April 18, 2026 22:17
@pandaji pandaji marked this pull request as ready for review April 19, 2026 01:41
@k8s-ci-robot k8s-ci-robot requested a review from justinsb April 19, 2026 01:42
@pandaji pandaji changed the title [WIP] Add helm chart for agent sandbox Apr 19, 2026
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 19, 2026
@aditya-shantanu

Copy link
Copy Markdown
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 20, 2026
Comment thread k8s/controller.yaml
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 22, 2026
@pandaji pandaji requested a review from janetkuo April 22, 2026 02:33
@barney-s

Copy link
Copy Markdown
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 25, 2026
@pandaji pandaji force-pushed the add-helm-chart-for-agent-sandbox branch from de9dd41 to f8fef42 Compare April 25, 2026 02:23
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2026
@pandaji

pandaji commented Apr 25, 2026

Copy link
Copy Markdown
Contributor Author

Rebased to get the latest go type in main. Reconciled ci.yml conflicts in previous commits.
PTAL, thanks. @barney-s

@barney-s

Copy link
Copy Markdown
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2026
@pandaji pandaji force-pushed the add-helm-chart-for-agent-sandbox branch from 00284fc to 41adc6b Compare April 29, 2026 00:35
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2026
@pandaji

pandaji commented Apr 29, 2026

Copy link
Copy Markdown
Contributor Author

@barney-s @janetkuo The main moves fast and the go type changed again.
I just rebased to pick up the latest.
PTAL and appreciate your immediate review on this one.

@pandaji

pandaji commented Apr 29, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

@pandaji: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
presubmit-agent-sandbox-benchmarks-kops-gcp 41adc6b link false /test presubmit-agent-sandbox-benchmarks-kops-gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pandaji

pandaji commented Apr 29, 2026

Copy link
Copy Markdown
Contributor Author

presubmit-agent-sandbox-benchmarks-kops-gcp

failed with Error: error calling Boskos: Post "boskos.test-pods.svc.cluster.local/acquire?type=gcp-project&state=free&dest=busy": unsupported protocol scheme ""

Looks like a misconfiguration in the test job?

@pandaji

pandaji commented Apr 29, 2026

Copy link
Copy Markdown
Contributor Author

Discuss on Slack. It is not required yet and can be ignored now.

Root case PR - kubernetes/test-infra#36884 (review).

@aditya-shantanu

Copy link
Copy Markdown
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2026
@barney-s

Copy link
Copy Markdown
Collaborator

/lgtm

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barney-s, janetkuo, pandaji

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@janetkuo janetkuo removed this from Agent Sandbox Apr 29, 2026
@k8s-ci-robot k8s-ci-robot merged commit 8a2c5a8 into kubernetes-sigs:main Apr 29, 2026
10 of 11 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Agent Sandbox Apr 29, 2026
khirotaka pushed a commit to khirotaka/agent-sandbox that referenced this pull request Jun 12, 2026
* squash commits, only add helm charts

* codegen to pickup the latest go type
alexatakvelon pushed a commit to volatilemolotov/agent-sandbox that referenced this pull request Jun 24, 2026
* squash commits, only add helm charts

* codegen to pickup the latest go type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. ready-for-review size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

6 participants