Add helm chart for agent sandbox#618
Conversation
✅ Deploy Preview for agent-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Welcome @pandaji! |
|
Hi @pandaji. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Pull request overview
Adds a Helm chart–based installation path for the agent-sandbox controller (and optional extensions), migrating generated CRDs/RBAC into the chart and wiring CI/tools to keep generated assets synchronized.
Changes:
- Replace legacy static Kubernetes manifests with a Helm chart (templates + values + README).
- Move controller-gen outputs (CRDs/RBAC) to
helm/crdsandhelm/templates, and update docs accordingly. - Add tooling/CI checks to keep generated outputs up-to-date and enforce chart version bumping when generated assets change.
Reviewed changes
Copilot reviewed 22 out of 28 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| k8s/extensions.controller.yaml | Removes legacy extensions Deployment manifest. |
| k8s/controller.yaml | Removes legacy core install manifest (namespace/SA/RBAC/service/deploy). |
| helm/Chart.yaml | Introduces Helm chart metadata. |
| helm/values.yaml | Adds chart values for image/controller flags/resources/scheduling and extensions toggle. |
| helm/README.md | Documents Helm install/upgrade/uninstall and values reference. |
| helm/templates/_helpers.tpl | Adds helper templates (labels, namespace, image reference). |
| helm/templates/_controller-args.generated.tpl | Generates controller CLI args from Helm values. |
| helm/templates/namespace.yaml | Optionally creates the target namespace. |
| helm/templates/serviceaccount.yaml | Creates controller ServiceAccount. |
| helm/templates/service.yaml | Exposes metrics Service. |
| helm/templates/deployment.yaml | Deploys controller with probes, args, and resource/scheduling knobs. |
| helm/templates/rbac.generated.yaml | Adds generated core ClusterRole rules for the controller. |
| helm/templates/clusterrolebinding.yaml | Binds core ClusterRole to controller ServiceAccount. |
| helm/templates/extensions-rbac.generated.yaml | Adds generated extensions ClusterRole rules. |
| helm/templates/clusterrolebinding-extensions.yaml | Conditionally binds extensions ClusterRole when extensions are enabled. |
| helm/crds/agents.x-k8s.io_sandboxes.yaml | Packages generated Sandbox CRD for Helm install. |
| helm/crds/extensions.agents.x-k8s.io_sandboxclaims.yaml | Packages generated SandboxClaim CRD for Helm install. |
| helm/crds/extensions.agents.x-k8s.io_sandboxtemplates.yaml | Packages generated SandboxTemplate CRD for Helm install. |
| helm/crds/extensions.agents.x-k8s.io_sandboxwarmpools.yaml | Packages generated SandboxWarmPool CRD for Helm install. |
| docs/development.md | Updates development deployment instructions to use Helm and helm/crds. |
| docs/configuration.md | Reframes configuration docs around Helm values and examples. |
| README.md | Updates top-level install guidance to point to Helm chart README. |
| codegen.go | Redirects controller-gen CRD/RBAC outputs to Helm chart directories. |
| dev/tools/fix-helm-values | Adds generator to sync Helm values/args template from controller flags. |
| dev/tools/bump-chart-version | Adds script to bump chart patch version when generated chart files change. |
| dev/tools/fix-go-generate | Runs go generate then bumps chart version when generated outputs change. |
| dev/ci/presubmits/test-autogen-up-to-date | Adds check ensuring chart version bump accompanies generated Helm asset changes. |
| .github/workflows/ci.yml | Adds verify-generate CI job and broadens path triggers to include Helm/codegen-related paths. |
00bbf5d to
e293a91
Compare
|
/ok-to-test |
|
/lgtm |
de9dd41 to
f8fef42
Compare
|
Rebased to get the latest go type in main. Reconciled ci.yml conflicts in previous commits. |
|
/lgtm |
00284fc to
41adc6b
Compare
|
/retest |
|
@pandaji: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
presubmit-agent-sandbox-benchmarks-kops-gcp failed with Error: error calling Boskos: Post "boskos.test-pods.svc.cluster.local/acquire?type=gcp-project&state=free&dest=busy": unsupported protocol scheme "" Looks like a misconfiguration in the test job? |
|
Discuss on Slack. It is not required yet and can be ignored now. Root case PR - kubernetes/test-infra#36884 (review). |
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: barney-s, janetkuo, pandaji The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* squash commits, only add helm charts * codegen to pickup the latest go type
* squash commits, only add helm charts * codegen to pickup the latest go type
For Issue #483