Skip to content

ci: declare contents: read on check-api-docs and check#796

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
arpitjain099:ci/add-permissions
May 15, 2026
Merged

ci: declare contents: read on check-api-docs and check#796
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
arpitjain099:ci/add-permissions

Conversation

@arpitjain099

Copy link
Copy Markdown
Contributor

Adds an explicit permissions: contents: read block to the two CI workflows that hadn't declared their token scope. Both only run local make/script commands to verify generated docs and KEP table-of-contents.

YAML validated locally.

- check-api-docs.yml verifies that generated API docs match source.
- check.yml runs the KEP TOC update/verify scripts on docs changes.

Neither writes to GitHub; both only run local make/scripts.

Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
@netlify

netlify Bot commented May 13, 2026

Copy link
Copy Markdown

Deploy Preview for agent-sandbox canceled.

Name Link
🔨 Latest commit e78e78e
🔍 Latest deploy log https://app.netlify.com/projects/agent-sandbox/deploys/6a04b10a80db8d0008297f1c
@k8s-ci-robot k8s-ci-robot requested review from barney-s and janetkuo May 13, 2026 11:30
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Welcome @arpitjain099!

It looks like this is your first PR to kubernetes-sigs/agent-sandbox 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/agent-sandbox has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 13, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @arpitjain099. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 13, 2026
@janetkuo janetkuo requested a review from Copilot May 13, 2026 12:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens GitHub Actions security posture by explicitly setting the default GITHUB_TOKEN permission to contents: read for the two CI workflows that only need to checkout and run local verification commands (API doc generation check and KEP TOC check).

Changes:

  • Add workflow-level permissions: contents: read to .github/workflows/check.yml.
  • Add workflow-level permissions: contents: read to .github/workflows/check-api-docs.yml.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/check.yml Declares contents: read at the workflow level for the TOC verification workflow.
.github/workflows/check-api-docs.yml Declares contents: read at the workflow level for the API docs generation/verification workflow.
@barney-s

Copy link
Copy Markdown
Collaborator

Thanks @arpitjain099

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arpitjain099, barney-s

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2026
@barney-s

Copy link
Copy Markdown
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 15, 2026
@k8s-ci-robot k8s-ci-robot merged commit b7c27b8 into kubernetes-sigs:main May 15, 2026
9 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Agent Sandbox May 15, 2026
khirotaka pushed a commit to khirotaka/agent-sandbox that referenced this pull request Jun 12, 2026
…gs#796)

- check-api-docs.yml verifies that generated API docs match source.
- check.yml runs the KEP TOC update/verify scripts on docs changes.

Neither writes to GitHub; both only run local make/scripts.

Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
alexatakvelon pushed a commit to volatilemolotov/agent-sandbox that referenced this pull request Jun 24, 2026
…gs#796)

- check-api-docs.yml verifies that generated API docs match source.
- check.yml runs the KEP TOC update/verify scripts on docs changes.

Neither writes to GitHub; both only run local make/scripts.

Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. ready-for-review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

5 participants