Skip to content

api/controllers: graduate API from v1alpha1 to v1beta1 and update controller logic.#817

Merged
k8s-ci-robot merged 3 commits into
kubernetes-sigs:mainfrom
SHRUTI6991:beta_api
May 19, 2026
Merged

api/controllers: graduate API from v1alpha1 to v1beta1 and update controller logic.#817
k8s-ci-robot merged 3 commits into
kubernetes-sigs:mainfrom
SHRUTI6991:beta_api

Conversation

@SHRUTI6991

@SHRUTI6991 SHRUTI6991 commented May 18, 2026

Copy link
Copy Markdown
Contributor

Working on #740

Description

This PR officially graduates the agent-sandbox API from v1alpha1 to v1beta1 directly on main for the upcoming release cycle.

Per the maintainer consensus in our API alignment and community discussion, we have opted to bypass the introduction of complex conversion web-hooks and their associated roundtrip logic debt and going forward with the Drop and Adopt strategy for API graduation. Since alpha APIs carry no structural compatibility or graduation guarantees under official Kubernetes API Deprecation Policy, this PR completely drops support for v1alpha1 and establishes v1beta1 as a clean-slate schema.

To maintain a healthy CI pipeline, this PR combines the API structural changes with the necessary controller reconciliation logic refactoring.

Breaking Changes (v1beta1)

  • Directory Migration: Removed pkg/api/v1alpha1/ and introduced pkg/api/v1beta1/.
  • Controller Update - The controller is based off of the latest v1beta1 API.
  • Test files - Upgraded E2E and unit test files.
  • API document - had to upgrade generate-api-docs to prevent CI failure.
  • Client set - New client set generation from v1beta1

Release notes

This commit initiates the v1beta1 graduation by dropping the legacy alpha schemas and updating the core and extension controllers to maintain compilation and functional parity. 
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 18, 2026
@netlify

netlify Bot commented May 18, 2026

Copy link
Copy Markdown

Deploy Preview for agent-sandbox canceled.

Name Link
🔨 Latest commit c0463f3
🔍 Latest deploy log https://app.netlify.com/projects/agent-sandbox/deploys/6a0caca4a075ad0008fcbd4f
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 18, 2026
@SHRUTI6991 SHRUTI6991 marked this pull request as ready for review May 18, 2026 21:53
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 18, 2026
@janetkuo janetkuo requested a review from Copilot May 18, 2026 22:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the project’s public API surface from v1alpha1 to v1beta1, updating generated clients, controller references, tests, examples, CRDs, docs, and SDK constants to target the beta API.

Changes:

  • Renames core and extension API packages, generated clients/listers/informers, and controller/test references to v1beta1.
  • Updates CRDs, Helm CRDs, examples, docs, and e2e fixtures to use the new API versions.
  • Adjusts SDK/client helpers and observability tests for the new generated client interfaces.

Reviewed changes

Copilot reviewed 163 out of 174 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
AGENTS.md Updates repository guidance to reference v1beta1 APIs.
README.md Updates quickstart Sandbox manifest API version.
api/v1beta1/doc.go Renames core API package documentation to v1beta1.
api/v1beta1/groupversion_info.go Updates core API GroupVersion to v1beta1.
api/v1beta1/sandbox_types.go Renames core API package to v1beta1.
api/v1beta1/zz_generated.deepcopy.go Updates generated deepcopy package name.
clients/go/sandbox/client_test.go Updates Go SDK tests to use v1beta1 clients/types.
clients/go/sandbox/k8s.go Updates Go SDK Kubernetes helper to v1beta1 clients/types.
clients/go/sandbox/tracing_test.go Updates tracing tests to v1beta1 clients/types.
clients/k8s/clientset/versioned/clientset.go Updates generated core clientset accessor to v1beta1.
clients/k8s/clientset/versioned/fake/clientset_generated.go Updates fake core clientset accessor to v1beta1.
clients/k8s/clientset/versioned/fake/register.go Registers v1beta1 core API in fake client scheme.
clients/k8s/clientset/versioned/scheme/register.go Registers v1beta1 core API in client scheme.
clients/k8s/clientset/versioned/typed/api/v1beta1/api_client.go Updates generated typed core API client to v1beta1.
clients/k8s/clientset/versioned/typed/api/v1beta1/doc.go Updates generated typed client package name.
clients/k8s/clientset/versioned/typed/api/v1beta1/fake/doc.go Adds generated fake client package doc.
clients/k8s/clientset/versioned/typed/api/v1beta1/fake/fake_api_client.go Updates fake core typed client to v1beta1.
clients/k8s/clientset/versioned/typed/api/v1beta1/fake/fake_sandbox.go Updates fake Sandbox typed client to v1beta1.
clients/k8s/clientset/versioned/typed/api/v1beta1/generated_expansion.go Updates generated expansion package.
clients/k8s/clientset/versioned/typed/api/v1beta1/sandbox.go Updates generated Sandbox typed client.
clients/k8s/extensions/clientset/versioned/clientset.go Updates generated extension clientset accessor to v1beta1.
clients/k8s/extensions/clientset/versioned/fake/clientset_generated.go Updates fake extension clientset accessor to v1beta1.
clients/k8s/extensions/clientset/versioned/fake/register.go Registers v1beta1 extension API in fake client scheme.
clients/k8s/extensions/clientset/versioned/scheme/register.go Registers v1beta1 extension API in client scheme.
clients/k8s/extensions/clientset/versioned/typed/api/v1alpha1/fake/fake_sandboxtemplate.go Removes obsolete v1alpha1 fake SandboxTemplate client.
clients/k8s/extensions/clientset/versioned/typed/api/v1alpha1/fake/fake_sandboxwarmpool.go Removes obsolete v1alpha1 fake SandboxWarmPool client.
clients/k8s/extensions/clientset/versioned/typed/api/v1beta1/api_client.go Updates generated extension typed client to v1beta1.
clients/k8s/extensions/clientset/versioned/typed/api/v1beta1/doc.go Updates generated extension typed client package.
clients/k8s/extensions/clientset/versioned/typed/api/v1beta1/fake/doc.go Adds generated fake extension client package doc.
clients/k8s/extensions/clientset/versioned/typed/api/v1beta1/fake/fake_api_client.go Updates fake extension typed client to v1beta1.
clients/k8s/extensions/clientset/versioned/typed/api/v1beta1/fake/fake_sandboxclaim.go Updates fake SandboxClaim client to v1beta1.
clients/k8s/extensions/clientset/versioned/typed/api/v1beta1/fake/fake_sandboxtemplate.go Adds fake SandboxTemplate client for v1beta1.
clients/k8s/extensions/clientset/versioned/typed/api/v1beta1/fake/fake_sandboxwarmpool.go Adds fake SandboxWarmPool client for v1beta1.
clients/k8s/extensions/clientset/versioned/typed/api/v1beta1/generated_expansion.go Updates generated extension expansion package.
clients/k8s/extensions/clientset/versioned/typed/api/v1beta1/sandboxclaim.go Updates SandboxClaim typed client.
clients/k8s/extensions/clientset/versioned/typed/api/v1beta1/sandboxtemplate.go Updates SandboxTemplate typed client.
clients/k8s/extensions/clientset/versioned/typed/api/v1beta1/sandboxwarmpool.go Updates SandboxWarmPool typed client.
clients/k8s/extensions/informers/externalversions/api/interface.go Updates extension informer group accessor to v1beta1.
clients/k8s/extensions/informers/externalversions/api/v1beta1/interface.go Updates extension informer package.
clients/k8s/extensions/informers/externalversions/api/v1beta1/sandboxclaim.go Updates SandboxClaim informer.
clients/k8s/extensions/informers/externalversions/api/v1beta1/sandboxtemplate.go Updates SandboxTemplate informer.
clients/k8s/extensions/informers/externalversions/api/v1beta1/sandboxwarmpool.go Updates SandboxWarmPool informer.
clients/k8s/extensions/informers/externalversions/generic.go Updates generic extension informer mapping.
clients/k8s/extensions/listers/api/v1beta1/expansion_generated.go Updates extension lister expansion package.
clients/k8s/extensions/listers/api/v1beta1/sandboxclaim.go Updates SandboxClaim lister.
clients/k8s/extensions/listers/api/v1beta1/sandboxtemplate.go Updates SandboxTemplate lister.
clients/k8s/extensions/listers/api/v1beta1/sandboxwarmpool.go Updates SandboxWarmPool lister.
clients/k8s/informers/externalversions/api/interface.go Updates core informer group accessor to v1beta1.
clients/k8s/informers/externalversions/api/v1beta1/interface.go Updates core informer package.
clients/k8s/informers/externalversions/api/v1beta1/sandbox.go Updates Sandbox informer.
clients/k8s/informers/externalversions/generic.go Updates generic core informer mapping.
clients/k8s/listers/api/v1beta1/expansion_generated.go Updates core lister expansion package.
clients/k8s/listers/api/v1beta1/sandbox.go Updates Sandbox lister.
clients/python/agentic-sandbox-client/gateway-kind/python-sandbox-template.yaml Updates Python client Gateway template manifest.
clients/python/agentic-sandbox-client/k8s_agent_sandbox/constants.py Updates Python SDK custom-resource API versions.
clients/python/agentic-sandbox-client/python-counter-template.yaml Updates Python counter template manifest.
clients/python/agentic-sandbox-client/python-sandbox-template.yaml Updates Python sandbox template manifest.
cmd/agent-sandbox-controller/main.go Registers extension v1beta1 APIs in controller manager.
dev/load-test/cluster-loader-sandbox.yaml Updates load-test Sandbox manifest.
dev/load-test/test-recipes/rapid-burst-test.yaml Updates load-test watcher object versions.
dev/load-test/test-recipes/templates/cluster-loader-sandbox-claim.yaml Updates load-test SandboxClaim template.
dev/load-test/test-recipes/templates/cluster-loader-sandbox-template.yaml Updates load-test SandboxTemplate template.
dev/load-test/test-recipes/templates/cluster-loader-warmpool.yaml Updates load-test SandboxWarmPool template.
dev/tools/client-gen-go.sh Points client generation at v1beta1 API packages.
docs/api.md Updates generated API reference version strings.
docs/keps/174-metadata-propagation/README.md Updates KEP sample type reference.
examples/aio-sandbox/aio-sandbox.yaml Updates example Sandbox manifest.
examples/analytics-tool/analytics-tool/sandbox-python.yaml Updates analytics Sandbox manifest.
examples/analytics-tool/jupyterlab.yaml Updates analytics JupyterLab Sandbox manifest.
examples/chrome-sandbox/README.md Updates Chrome example API version.
examples/composing-sandbox-nw-policies/README.md Updates composing-policy example versions.
examples/composing-sandbox-nw-policies/instance.yaml Updates custom example instance version.
examples/composing-sandbox-nw-policies/rgd.yaml Updates RGD and embedded Sandbox versions.
examples/gemini-cu-sandbox/sandbox-gemini-computer-use.yaml Updates Gemini template manifest.
examples/hello-world-sandbox/hello-world.yaml Updates hello-world Sandbox manifest.
examples/hermes-agent/sandbox.yaml Updates Hermes Sandbox manifest.
examples/hpa-swp-scaling/create-claim.py Updates Python load example API versions.
examples/hpa-swp-scaling/hpa.yaml Updates HPA scaleTargetRef API version.
examples/hpa-swp-scaling/python-sandbox-template.yaml Updates HPA SandboxTemplate manifest.
examples/hpa-swp-scaling/sandboxwarmpool.yaml Updates HPA SandboxWarmPool manifest.
examples/jupyterlab/experiment.md Updates JupyterLab experiment manifest.
examples/jupyterlab/jupyterlab-full.yaml Updates full JupyterLab manifest.
examples/jupyterlab/jupyterlab.yaml Updates JupyterLab Sandbox manifest.
examples/kata-gke-sandbox/README.md Updates Kata GKE documentation manifest.
examples/kata-gke-sandbox/sandbox-kata-gke.yaml Updates Kata GKE Sandbox manifest.
examples/kueue-agent-sandbox/README.md Updates Kueue example manifest.
examples/langchain/deployment.yaml Updates LangChain Sandbox manifest.
examples/manual-pdb/sandboxclaim.yaml Updates manual PDB SandboxClaim manifest.
examples/manual-pdb/sandboxtemplate.yaml Updates manual PDB SandboxTemplate manifest.
examples/openclaw-sandbox/openclaw-sandbox.yaml Updates OpenClaw Sandbox manifest.
examples/policy/kyverno/.chainsaw-tests/chainsaw-test.yaml Updates Chainsaw test API version.
examples/policy/kyverno/.chainsaw-tests/setup-sandbox.yaml Updates Kyverno test Sandbox manifest.
examples/policy/network-policy-management/README.md Updates network policy examples.
examples/policy/opa-gatekeeper/README.md Updates OPA Gatekeeper Sandbox examples.
examples/policy/opa-gatekeeper/config-sandbox-binding.yaml Updates Gatekeeper config API version.
examples/policy/opa-gatekeeper/template-sandbox-binding.yaml Updates comments referencing Sandbox API version.
examples/policy/policy-controller/README.md Updates policy-controller Sandbox example.
examples/policy/policy-controller/config-sandbox-binding.yaml Updates Gatekeeper config API version.
examples/policy/policy-controller/template-sandbox-binding.yaml Updates comments referencing Sandbox API version.
examples/policy/sandbox-automount-token-policy.yaml Updates VAP match API version.
examples/policy/vap/README.md Updates VAP Sandbox examples.
examples/policy/vap/policy_test.go Updates VAP tests to v1beta1 types.
examples/policy/vap/secure-sandbox-policy.yaml Updates VAP resource rule API version.
examples/python-runtime-sandbox/sandbox-python-kind.yaml Updates Python runtime Sandbox manifest.
examples/quickstart/README.md Updates quickstart extension manifests.
examples/quickstart/gvisor.md Updates gVisor quickstart claim manifest.
examples/quickstart/kata-containers.md Updates Kata quickstart claim manifest.
examples/sandbox-ksa/sandbox.yaml Updates service-account Sandbox manifest.
examples/vscode-sandbox/base/vscode-sandbox.yaml Updates VS Code base Sandbox manifest.
examples/vscode-sandbox/overlays/gvisor/patch-gvisor.yaml Updates VS Code gVisor patch version.
examples/vscode-sandbox/overlays/kata-mshv/patch-kata.yaml Updates VS Code Kata MSHV patch version.
examples/vscode-sandbox/overlays/kata/patch-kata.yaml Updates VS Code Kata patch version.
extensions/api/v1beta1/doc.go Renames extension API package documentation.
extensions/api/v1beta1/groupversion_info.go Updates extension API GroupVersion to v1beta1.
extensions/api/v1beta1/sandboxclaim_types.go Renames extension SandboxClaim API package/types references.
extensions/api/v1beta1/sandboxtemplate_types.go Updates SandboxTemplate API package and core type references.
extensions/api/v1beta1/sandboxwarmpool_types.go Updates SandboxWarmPool API package and markers.
extensions/api/v1beta1/zz_generated.deepcopy.go Updates extension deepcopy package/imports.
extensions/controllers/sandboxclaim_pod_exclusivity_test.go Updates extension controller test types.
extensions/controllers/sandboxtemplate_controller.go Updates SandboxTemplate reconciler to v1beta1.
extensions/controllers/sandboxtemplate_controller_test.go Updates SandboxTemplate reconciler tests.
extensions/controllers/utils.go Updates extension controller utility types/constants.
extensions/examples/llm.yaml Updates LLM template manifest.
extensions/examples/sandbox-claim.yaml Updates SandboxClaim example.
extensions/examples/sandboxclaim.yaml Updates SandboxClaim example.
extensions/examples/sandboxtemplate.yaml Updates SandboxTemplate example.
extensions/examples/sandboxwarmpool.yaml Updates SandboxWarmPool example.
extensions/examples/secure-sandboxtemplate.yaml Updates secure SandboxTemplate example.
helm/crds/agents.x-k8s.io_sandboxes.yaml Updates Helm Sandbox CRD served version.
helm/crds/extensions.agents.x-k8s.io_sandboxclaims.yaml Updates Helm SandboxClaim CRD served version.
helm/crds/extensions.agents.x-k8s.io_sandboxtemplates.yaml Updates Helm SandboxTemplate CRD served version.
helm/crds/extensions.agents.x-k8s.io_sandboxwarmpools.yaml Updates Helm SandboxWarmPool CRD served version.
internal/metrics/sandbox_collector.go Updates metrics collector to list v1beta1 Sandboxes.
internal/metrics/sandbox_collector_test.go Updates metrics collector tests.
k8s/crds/agents.x-k8s.io_sandboxes.yaml Updates Sandbox CRD served version.
k8s/crds/extensions.agents.x-k8s.io_sandboxclaims.yaml Updates SandboxClaim CRD served version.
k8s/crds/extensions.agents.x-k8s.io_sandboxtemplates.yaml Updates SandboxTemplate CRD served version.
k8s/crds/extensions.agents.x-k8s.io_sandboxwarmpools.yaml Updates SandboxWarmPool CRD served version.
site/content/docs/filesystem/_index.md Updates filesystem docs manifest.
site/content/docs/sandbox/custom_sandbox/custom_environment/source/template.yaml Updates custom sandbox source manifest.
site/content/docs/sandbox/lifecycle/_index.md Updates lifecycle docs manifest.
site/content/docs/sandbox/lifecycle/source/template.yaml Updates lifecycle source manifest.
site/content/docs/sandbox/snapshots/source/template.yaml Updates snapshots source manifest.
site/content/docs/use-cases/gvisor-isolation/_index.md Updates gVisor docs manifest.
site/content/docs/use-cases/kata-containers-isolation/_index.md Updates Kata docs manifest.
site/content/docs/volumes/gcsfuse-csi/_index.md Updates GCSFuse docs manifest.
site/content/docs/volumes/volume-claim-template/_index.md Updates volume claim template docs manifests.
site/content/docs/volumes/volume-claim-template/source/template.yaml Updates volume claim source manifest.
test/e2e/basic_test.go Updates basic e2e test to v1beta1.
test/e2e/chromesandbox_claim_test.go Updates Chrome claim benchmark to v1beta1.
test/e2e/chromesandbox_test.go Updates Chrome e2e test to v1beta1.
test/e2e/clients/python/framework/context.py Updates Python e2e helper API version.
test/e2e/clients/python/test_manifests/sandbox_template.yaml Updates Python e2e template manifest.
test/e2e/clients/python/test_manifests/sandbox_warmpool.yaml Updates Python e2e warm pool manifest.
test/e2e/extensions/pythonruntime_test.go Updates Python runtime e2e manifests/types.
test/e2e/extensions/sandboxclaim_metric_test.go Updates SandboxClaim metric e2e types.
test/e2e/extensions/shutdown_policy_test.go Updates extension shutdown policy tests.
test/e2e/extensions/warmpool_rollout_test.go Updates warm pool rollout tests.
test/e2e/extensions/warmpool_sandbox_watcher_test.go Updates warm pool watcher tests.
test/e2e/framework/client.go Updates e2e framework GVK/type mapping.
test/e2e/framework/context.go Registers extension v1beta1 scheme in e2e framework.
test/e2e/framework/predicates/sandbox.go Updates Sandbox status predicates.
test/e2e/framework/watchset_test.go Updates watchset test GVR version.
test/e2e/parallelism_test.go Updates parallel SandboxClaim tests.
test/e2e/replicas_test.go Updates replica behavior tests.
test/e2e/shutdown_test.go Updates shutdown behavior tests.
test/e2e/volumeclaimtemplate_test.go Updates volume claim template test.
Files not reviewed (8)
  • clients/k8s/clientset/versioned/clientset.go: Language not supported
  • clients/k8s/clientset/versioned/fake/clientset_generated.go: Language not supported
  • clients/k8s/clientset/versioned/fake/register.go: Language not supported
  • clients/k8s/clientset/versioned/scheme/register.go: Language not supported
  • clients/k8s/extensions/clientset/versioned/clientset.go: Language not supported
  • clients/k8s/extensions/clientset/versioned/fake/clientset_generated.go: Language not supported
  • clients/k8s/extensions/clientset/versioned/fake/register.go: Language not supported
  • clients/k8s/extensions/clientset/versioned/scheme/register.go: Language not supported
Comments suppressed due to low confidence (1)

extensions/api/v1beta1/groupversion_info.go:15

  • This package comment describes the extension API group as agents; it should say extensions to match the +groupName=extensions.agents.x-k8s.io marker below and the resources defined in this package.
Comment thread examples/chrome-sandbox/README.md Outdated
@@ -1,4 +1,4 @@
apiVersion: agents.x-k8s.io/v1alpha1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned about updating docs/examples now. Technically users should follow docs in specific tag/branch, but users typically read from main as it's the default, and our site will be broken by this given that users can't use v1beta1 yet and users can't read site based on release version. This will cause confusion to users who install from releases.

Let's keep doc updates separate and as the last step, per #740 (comment).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

  1. For the site strategy, I documented the proposal here: [Epic] Graduate API to Beta #740 (comment).

  2. In this PR, the changes are only in controller + api + crd + clients + test. The only 2 exception being:

    a. docs/api.md - this is part of the CI API generate test. It required the doc to be updated based on the current API.
    b. examples/vap/policy_test.go - This test ran as part of go mod tidy CI.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2026
@janetkuo janetkuo added this to the Beta milestone May 19, 2026
@SHRUTI6991 SHRUTI6991 force-pushed the beta_api branch 2 times, most recently from 21e5fc0 to 4346693 Compare May 19, 2026 18:02
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2026
@@ -16,7 +16,7 @@ spec:
singular: sandbox

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change the helm/crds later? It's similar to the comment around docs

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the CI will break. CI checks against fix-go-generate which generates the CRD against API.

@janetkuo janetkuo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janetkuo, SHRUTI6991

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2026
@k8s-ci-robot k8s-ci-robot merged commit 42020b4 into kubernetes-sigs:main May 19, 2026
13 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Agent Sandbox May 19, 2026
khirotaka pushed a commit to khirotaka/agent-sandbox that referenced this pull request Jun 12, 2026
…troller logic. (kubernetes-sigs#817)

* api/controllers: graduate API to v1beta1 and update controller logic.

* Add API doc.

* CI failures.
alexatakvelon pushed a commit to volatilemolotov/agent-sandbox that referenced this pull request Jun 24, 2026
…troller logic. (kubernetes-sigs#817)

* api/controllers: graduate API to v1beta1 and update controller logic.

* Add API doc.

* CI failures.
dongjiang1989 added a commit to dongjiang1989/agent-sandbox that referenced this pull request Jun 26, 2026
The core Sandbox CRD was graduated to v1beta1 (kubernetes-sigs#817) and
no longer serves v1alpha1. Update both the manifest and the inline
example in README.md so kubectl apply succeeds against current clusters.
kubernetes-prow Bot pushed a commit that referenced this pull request Jun 29, 2026
* add playwright sandbox and Dockerfile

Signed-off-by: dongjiang <dongjiang1989@126.com>

* add label

Signed-off-by: dongjiang <dongjiang1989@126.com>

* fix(playwright-sandbox): bump apiVersion from v1alpha1 to v1beta1

The core Sandbox CRD was graduated to v1beta1 (#817) and
no longer serves v1alpha1. Update both the manifest and the inline
example in README.md so kubectl apply succeeds against current clusters.

* docs(playwright-sandbox): address CodeRabbit review feedback

- Add 'text' language tag to the sample output fenced block for
  markdownlint compliance.
- Define the IMAGE variable before its first use in the deploy
  instructions so users can copy-paste the commands without guessing.

* fix(playwright-sandbox): keep container alive with sleep infinity

The one-shot script + restartPolicy: Never caused the pod to reach
Succeeded immediately, making kubectl cp fail with "cannot exec into a
container in a completed pod". Append 'sleep infinity' to the command so
the Sandbox stays Running and users can retrieve the screenshot via
kubectl cp / kubectl exec as documented.

---------

Signed-off-by: dongjiang <dongjiang1989@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ready-for-review size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

4 participants