Add --transport option to port-forward#1385
Conversation
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
approved
|
@kubernetes-sigs/cri-tools-maintainers PTAL |
| Flags: []cli.Flag{ | ||
| &cli.StringFlag{ | ||
| Name: transportFlag, | ||
| Aliases: []string{"r"}, |
There was a problem hiding this comment.
Was r chosen here because t was already taken?
There was a problem hiding this comment.
Yes, on exec and attach.
|
/approve |
The latest Kubernetes beta supports using websockets for port-forward. We now introduce a similar option to `attach` and `exec` to be able to select the new transport. See: kubernetes/enhancements#4006 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
k8s-1.30-beta.0
branch
from
e1f9c9a to
175bbd5
Compare
|
/lgtm |
|
@kwilczynski: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwilczynski, saschagrunert, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
What type of PR is this?
/kind feature
What this PR does / why we need it:
The latest Kubernetes beta supports using websockets for port-forward. We now introduce a similar option to
attachandexecto be able to select the new transport.See: kubernetes/enhancements#4006
Which issue(s) this PR fixes:
Follow-up on #1383
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?