Skip to content

Update Device Health fields description for KEP-4680#128299

Merged
k8s-ci-robot merged 3 commits into
kubernetes:masterfrom
SergeyKanzhelev:updateDHS
Oct 28, 2024
Merged

Update Device Health fields description for KEP-4680#128299
k8s-ci-robot merged 3 commits into
kubernetes:masterfrom
SergeyKanzhelev:updateDHS

Conversation

@SergeyKanzhelev

@SergeyKanzhelev SergeyKanzhelev commented Oct 24, 2024

Copy link
Copy Markdown
Member

What type of PR is this?

/kind cleanup
/kind documentation

KEP: kubernetes/enhancements#4680

Just aligning with the latest KEP update.

/sig node

Does this PR introduce a user-facing change?

NONE
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/documentation Categorizes issue or PR as related to documentation. sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/code-generation kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Oct 24, 2024
@k8s-triage-robot

k8s-triage-robot commented Oct 24, 2024

Copy link
Copy Markdown

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.
@BenTheElder

BenTheElder commented Oct 24, 2024

Copy link
Copy Markdown
Member

/triage accepted
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 24, 2024
@BenTheElder

BenTheElder commented Oct 24, 2024

Copy link
Copy Markdown
Member

/sig architecture
/remove-sig api-machinery
@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 24, 2024
@SergeyKanzhelev

SergeyKanzhelev commented Oct 25, 2024

Copy link
Copy Markdown
Member Author

@thockin can you please review this? This is mostly comments, and they were reviewed during the KEP review already.

Also it is a small pre-work for the DRA support.

/assign @thockin
thockin
thockin reviewed Oct 25, 2024
View reviewed changes
Comment thread pkg/apis/core/types.go Outdated
Comment thread pkg/apis/core/types.go Outdated
Comment thread pkg/apis/core/types.go Outdated
Comment thread pkg/apis/core/validation/validation.go Outdated
@SergeyKanzhelev

SergeyKanzhelev commented Oct 26, 2024

Copy link
Copy Markdown
Member Author

@thockin thank you for your review!
thockin
thockin reviewed Oct 28, 2024
View reviewed changes

@thockin thockin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2024
@k8s-ci-robot

k8s-ci-robot commented Oct 28, 2024

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: eb5fa040e2a908de359609d023cac8e347c38235
@k8s-ci-robot

k8s-ci-robot commented Oct 28, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SergeyKanzhelev, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2024
@k8s-ci-robot k8s-ci-robot merged commit 86b9986 into kubernetes:master Oct 28, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Oct 28, 2024
@SergeyKanzhelev SergeyKanzhelev deleted the updateDHS branch October 28, 2024 22:22
@pacoxu pacoxu mentioned this pull request Nov 8, 2024
Open
19 tasks
@pohly pohly mentioned this pull request Nov 26, 2024
Merged
mhan8796 pushed a commit to mhan8796/kubernetes that referenced this pull request Jun 27, 2026
@k8s-ci-robot
Merge pull request kubernetes#128299 from SergeyKanzhelev/updateDHS
181c802 
Update Device Health fields description for KEP-4680
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

5 participants

@SergeyKanzhelev @k8s-triage-robot @BenTheElder @k8s-ci-robot @thockin