DRA: Add configurable health check timeout per device#135147
Merged
Conversation
Implements device-specific health check timeouts in the DRA health monitoring system as defined in KEP-4680. This allows DRA drivers to specify custom timeout values for individual devices through the gRPC health API. Changes: - Add HealthCheckTimeout field to state.DeviceHealth struct to store device-specific timeout durations - Add health_check_timeout_seconds field to DeviceHealth proto message in the DRA health gRPC API (v1alpha1) - Update manager.go to extract timeout from gRPC responses and apply DefaultHealthTimeout (30s) when not specified - Handle negative timeout values defensively by logging a warning and falling back to the default timeout - Simplify healthinfo.go by removing redundant fallback logic since timeouts are now always set at creation time - Update tests to include HealthCheckTimeout in test fixtures The timeout behavior is: - Positive values: Use the specified timeout in seconds - Zero or unspecified: Use DefaultHealthTimeout (30 seconds) - Negative values: Log warning and use DefaultHealthTimeout This implementation provides flexibility for DRA drivers to define appropriate health check intervals for different device types while maintaining backward compatibility through sensible defaults. Ref: KEP-4680 (Add Resource Health to Pod Status) Ref: kubernetes/enhancements#5476 Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
Signed-off-by: Harshal Patil <12152047+harche@users.noreply.github.com>
k8s-ci-robot
added
do-not-merge/work-in-progress
github-project-automation
Bot
added this to
SIG Node: code and documentation PRs and Dynamic Resource Allocation
k8s-ci-robot
removed
the
do-not-merge/needs-sig
github-project-automation
Bot
moved this to Triage
in SIG Node: code and documentation PRs
Contributor
Author
|
/retest-required |
Contributor
Author
|
/retest pull-kubernetes-node-e2e-containerd |
k8s-ci-robot
added
release-note-none
Contributor
Author
|
/retest-required |
Contributor
|
@harche can you update with a release note #133752 (comment)? |
k8s-ci-robot
added
release-note
Contributor
|
/sig node |
Contributor
|
@harche thank you for opening this to get the change through. |
Contributor
|
@harche: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Contributor
|
cc. @SergeyKanzhelev |
Contributor
Author
|
/retest-required |
Contributor
Author
|
/assign @liggitt Ready for final approval. |
Member
|
/kind feature |
k8s-ci-robot
added
kind/feature
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harche, liggitt, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Contributor
Author
|
/label priority/important-soon |
Contributor
Author
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
github-project-automation
Bot
moved this from Triage
to Done
in SIG Node: code and documentation PRs
Open
19 tasks
mhan8796
pushed a commit
to mhan8796/kubernetes
that referenced
this pull request
Jun 27, 2026
DRA: Add configurable health check timeout per device
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
Implements device-specific health check timeouts in the DRA health monitoring system as defined in KEP-4680. This allows DRA drivers to specify custom timeout values for individual devices through the gRPC health API.
Please note that, this PR builds on top of #133752. It has been created in the interest of time remaining for the code freeze.
Which issue(s) this PR is related to:
Ref: KEP-4680 (Add Resource Health to Pod Status)
Ref: kubernetes/enhancements#5476
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: