Skip to content

KEP-4680: Add tests to validate ShareID does not interfere with DRA Resource Health Status#136758

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
harche:shareid_test
Feb 25, 2026
Merged

KEP-4680: Add tests to validate ShareID does not interfere with DRA Resource Health Status#136758
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
harche:shareid_test

Conversation

@harche

@harche harche commented Feb 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Adds unit and e2e_node tests to validate that ShareID (DRAConsumableCapacity) does not interfere with Resource Health Status (KEP-4680).
These tests address a gap identified during the review of #134520, where @SergeyKanzhelev noted the need for tests to ensure both features work correctly together.

The new tests verify:

  • Health updates propagate correctly to pods using devices with ShareID
  • Multiple pods sharing the same device (via different ShareIDs) all receive health notifications
  • Pod status correctly reflects health for devices allocated with ShareID
  • Health status transitions (Healthy → Unhealthy → Healthy) work with ShareID allocations

Which issue(s) this PR is related to:

Fixes : #135190

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/4680
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 4, 2026
@k8s-ci-robot

k8s-ci-robot commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Feb 4, 2026
@k8s-ci-robot k8s-ci-robot added area/kubelet area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. wg/device-management Categorizes an issue or PR as relevant to WG Device Management. labels Feb 4, 2026
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Feb 4, 2026
@harche

harche commented Feb 4, 2026

Copy link
Copy Markdown
Contributor Author

/retitle WIP: KEP-4680: Add tests to validate ShareID does not interfere with DRA Resource Health Status
@k8s-ci-robot k8s-ci-robot changed the title WIP: KEP-4680: Add tests to validate ShareID does not interfere with DRA Resource He… Feb 4, 2026
@harche

harche commented Feb 4, 2026

Copy link
Copy Markdown
Contributor Author

/test pull-kubernetes-unit-windows-master
@harche

harche commented Feb 5, 2026

Copy link
Copy Markdown
Contributor Author

/test pull-kubernetes-node-kubelet-serial-containerd
@pohly pohly moved this from 🆕 New to 🏗 In progress in Dynamic Resource Allocation Feb 6, 2026
@bart0sh bart0sh moved this from Triage to Work in progress in SIG Node: code and documentation PRs Feb 18, 2026
@harche harche changed the title WIP: KEP-4680: Add tests to validate ShareID does not interfere with DRA Resource Health Status Feb 18, 2026
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 18, 2026
@harche

harche commented Feb 18, 2026

Copy link
Copy Markdown
Contributor Author

/kind feature
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Feb 18, 2026
haircommander
haircommander reviewed Feb 18, 2026
View reviewed changes
Comment thread pkg/kubelet/cm/dra/manager_test.go Outdated
}
}

// genTestClaimInfoWithShareID generates claim info object with ShareID set on the device.

@haircommander haircommander Feb 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just extend genTestClaimInfo with shareID, and pass in nil in other cases it's called

@haircommander haircommander Feb 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or, maybe even better, we just call genTestClaimInfo below, and then add the ShareID to the object after.
haircommander
haircommander reviewed Feb 18, 2026
View reviewed changes
Comment thread test/e2e_node/dra_test.go

// createTestObjectsWithShareID creates test objects (DeviceClass, ResourceClaim, Pod) for testing
// ShareID with health status integration. The ShareID is included in the device allocation result.
func createTestObjectsWithShareID(ctx context.Context, f *framework.Framework, driverName, className, claimName, podName, poolName, deviceName string, shareID *apitypes.UID) *v1.Pod {

@haircommander haircommander Feb 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here as above, doesn't make sense to duplicate the function to me
@harche
Add tests to validate ShareID does not interfere with DRA Resource He…
62710a1 
…alth Status

Signed-off-by: Harshal Patil <12152047+harche@users.noreply.github.com>
@harche

harche commented Feb 19, 2026

Copy link
Copy Markdown
Contributor Author

/retest-required
@harche

harche commented Feb 19, 2026

Copy link
Copy Markdown
Contributor Author

/test pull-kubernetes-node-kubelet-serial-containerd
@pohly pohly moved this from 🏗 In progress to 👀 In review in Dynamic Resource Allocation Feb 20, 2026
@SergeyKanzhelev

SergeyKanzhelev commented Feb 25, 2026

Copy link
Copy Markdown
Member

/assign
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to PRs - Needs Reviewer in SIG Node CI/Test Board Feb 25, 2026
SergeyKanzhelev
SergeyKanzhelev approved these changes Feb 25, 2026
View reviewed changes

@SergeyKanzhelev SergeyKanzhelev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2026
@k8s-ci-robot

k8s-ci-robot commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: bda222fd41046449d7fe67a21ff11a9d3957a2d2
@k8s-ci-robot

k8s-ci-robot commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harche, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2026
@k8s-ci-robot k8s-ci-robot merged commit 1ec2776 into kubernetes:master Feb 25, 2026
22 of 23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.36 milestone Feb 25, 2026
@github-project-automation github-project-automation Bot moved this from Work in progress to Done in SIG Node: code and documentation PRs Feb 25, 2026
@github-project-automation github-project-automation Bot moved this from PRs - Needs Reviewer to Done in SIG Node CI/Test Board Feb 25, 2026
@harche harche deleted the shareid_test branch February 26, 2026 00:18
@pohly pohly moved this from 👀 In review to ✅ Done in Dynamic Resource Allocation Mar 2, 2026
@Rajalakshmi-Girish Rajalakshmi-Girish mentioned this pull request Mar 10, 2026
Open
19 tasks
@harche harche mentioned this pull request May 28, 2026
Merged
mhan8796 pushed a commit to mhan8796/kubernetes that referenced this pull request Jun 27, 2026
@k8s-ci-robot
Merge pull request kubernetes#136758 from harche/shareid_test
bb32971 
KEP-4680: Add tests to validate ShareID does not interfere with DRA Resource Health Status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.

6 participants

@harche @k8s-ci-robot @SergeyKanzhelev @haircommander @pohly @bart0sh