Revert "Merge pull request #3223 from xmudrii/fix-release-comparison"#3254
Merged
Conversation
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
approved
k8s-ci-robot
added
the
lgtm
saschagrunert
approved these changes
Sep 7, 2023
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert, Verolop, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
10 tasks
saschagrunert
added a commit
to saschagrunert/release
that referenced
this pull request
May 14, 2024
Fixing the very specific use case of the failing semver comparison mentioned in kubernetes/kubernetes#117115 Follow-up on kubernetes#3223 and kubernetes#3254 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
added a commit
to saschagrunert/release
that referenced
this pull request
May 28, 2024
Fixing the very specific use case of the failing semver comparison mentioned in kubernetes/kubernetes#117115 Follow-up on kubernetes#3223 and kubernetes#3254 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
added a commit
to saschagrunert/release
that referenced
this pull request
May 29, 2024
Fixing the very specific use case of the failing semver comparison mentioned in kubernetes/kubernetes#117115 Follow-up on kubernetes#3223 and kubernetes#3254 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind regression
What this PR does / why we need it:
I unintentionally made a regression in #3223 that's now causing kubernetes/sig-release#2333
Let's revert this change and I'll get back to it with a proper fix.
Which issue(s) this PR fixes:
Fixes kubernetes/sig-release#2333
Does this PR introduce a user-facing change?
/assign @cpanato @saschagrunert @Verolop
cc @kubernetes/release-engineering