Fix bare except clauses with specific exception types#3764
Open
yurekami wants to merge 2 commits into
Open
Conversation
- Fix duplicate function name bug in controller.py where `worker_api_get_status` was defined twice, causing the test_connection endpoint to shadow the worker status endpoint - Fix PEP 8 violation: use `is None` instead of `== None` in model_worker.py - Fix type comparison: use `isinstance()` instead of `type() ==` in openai_api_server.py for better Pythonic style - Add `/health` endpoint to both controller and openai_api_server for load balancer and orchestration system compatibility 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Replace overly broad `except:` clauses with specific exception types to: - Prevent catching KeyboardInterrupt and SystemExit - Make error handling more explicit and debuggable - Follow Python best practices (PEP 8) Changes: - utils.py: Catch (KeyError, TypeError) in image moderation retry loop - api_provider.py: Catch (IndexError, AttributeError, KeyError) in Reka API stream iteration, also include error message in response - monitor.py: Catch (IndexError, KeyError) in model name lookup 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace overly broad
except:clauses with specific exception types to improve code safety and debuggability.Changes
utils.py:453except:except (KeyError, TypeError):Status.Codekeyapi_provider.py:1265except:except (IndexError, AttributeError, KeyError) as e:monitor.py:889except:except (IndexError, KeyError):Why This Matters
Bare
except:clauses catch all exceptions including:KeyboardInterrupt- prevents Ctrl+C from workingSystemExit- prevents clean shutdownGeneratorExit- breaks generator cleanupThis is a Python anti-pattern documented in PEP 8.
Test Plan
python -m py_compileon all modified files🤖 Generated with Claude Code