Pre-download socat to avoid test failing due to connectivity issues - #41035
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce WSLC test flakiness caused by transient network connectivity by switching the socat installation in tests from an online tdnf install socat to an offline install from pre-downloaded RPMs shipped with (or prepared into) the Microsoft.WSL.TestData package.
Changes:
- Added a PowerShell utility to download the latest
socatRPM (and select dependencies) into the test data folder layout. - Updated
WSLCTestsport-mapping validation to mount the test data directory and installsocatfrom local RPMs with repos disabled. - Bumped
Microsoft.WSL.TestDataNuGet dependency version to0.5.0.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tools/test/download-test-data-rpms.ps1 | New helper script to fetch socat + dependency RPMs into the test-data package layout. |
| test/windows/WSLCTests.cpp | Installs socat from mounted test data RPMs (offline) during port-mapping tests. |
| packages.config | Updates the Microsoft.WSL.TestData package version to pick up the new data content. |
Blue (OneBlue)
changed the title
Ben Hillis (benhillis)
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This change adds logic to pre-download the rpms for socat and its dependencies so we don't download it from the internet while the tests run. We've seen this causing a test failure in the past.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed