Remove comment in packages.config causing powershell parsing error - #41036
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes an XML comment from packages.config to prevent a PowerShell-based packages.config parsing step (used during CMake configure) from throwing Cannot index into a null array, while keeping NuGet restore/configure behavior unchanged.
Changes:
- Removed a TODO XML comment line from
packages.configthat was being interpreted as a node by the PowerShellSelect-Xmlpipeline. - Eliminated the noisy configure-time PowerShell exception without adding extra parsing complexity.
Ben Hillis (benhillis)
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This change removes the comment in packages.config. Configuring cmake with that comment it places gives:
The configuration still succeeds, but we might as well remove this. It's probably not worth adding complexity to the parsing script to support comments either
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed