Add missing error code mappings found in user visible errors - #41074
Merged
Feng Wang (chemwolf6922) merged 2 commits intoJul 15, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves user-visible error reporting by expanding the HRESULT→string mapping table so more telemetry/error paths render human-readable error identifiers (e.g., .../ERROR_TIMEOUT), and corrects an incorrect NTSTATUS mapping.
Changes:
- Add
HRESULT_FROM_NT(...)helper and switchSTATUS_SHUTDOWN_IN_PROGRESSmapping to NTSTATUS-based conversion. - Expand
g_commonErrorswith additional Win32/HRESULT/NTSTATUS mappings (includingERROR_TIMEOUT). - Add missing NTSTATUS constant definitions to
wdk.hused by the new mappings.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/windows/inc/wdk.h | Adds additional NTSTATUS constant definitions needed by error-string mapping. |
| src/windows/common/wslutil.cpp | Extends the common error-code-to-string mapping table and fixes NTSTATUS conversion for shutdown-in-progress. |
Ben Hillis (benhillis)
approved these changes
Jul 14, 2026
Feng Wang (chemwolf6922)
deleted the
user/chemwolf6922/convert-numeric-errors-in-user-visible-error-to-string
branch
July 15, 2026 02:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Some error codes in user visible errors are not converted to human readable strings. For example:
Wsl/Service/CreateInstance/CreateVm/0x800705b4should beWsl/Service/CreateInstance/CreateVm/ERROR_TIMEOUT.This PR adds mappings for missing error codes found in user visible error telemetries. And fixes the
STATUS_SHUTDOWN_IN_PROGRESSmapping.PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed