Fix config's handling of non-ascii characters - #41657
Merged
Feng Wang (chemwolf6922) merged 1 commit intoSep 22, 2026
Merged
Feng Wang (chemwolf6922) merged 1 commit into
Feng Wang (chemwolf6922) merged 1 commit into
Conversation
Copilot started reviewing on behalf of
Feng Wang (chemwolf6922)
September 21, 2026 08:01
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The reviewed changes address Unicode handling and include passing test coverage.
Review effort: Lite
Findings: None
What changed in this PR
Fixes .wslconfig parsing so non-ASCII values are preserved correctly.
Changes:
- Preserve values as wide strings before UTF-8 conversion.
- Add Unicode round-trip test coverage.
| File | Summary |
|---|---|
test/windows/UnitTests.cpp |
Adds Unicode path round-trip coverage. |
src/shared/configfile/configfile.cpp |
Preserves Unicode config values during parsing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Blue (OneBlue)
approved these changes
Sep 21, 2026
Feng Wang (chemwolf6922)
deleted the
user/chemwolf6922/fix-mangled-non-ascii-charactor-in-config-parsing
branch
September 22, 2026 02:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
When parsing the config file, non-ascii utf-16 values are casted into char. This will mangle non-ascii values in the config file. For example, a custom kernel path containing Chinese characters will cause
WSL_E_CUSTOM_KERNEL_NOT_FOUND.This PR removes the faulty static cast and stores the config value in wstring instead of string. So non-ascii values are preserved.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Modify test:
UnitTests::UnitTets::WriteWslConfig
Manually tested with a custom kernel with a path containing Chinese characters. Before the fix, wsl fails with:
After the fix, wsl boots correctly.