Prevent potential invalid access for string array pretty print - #41673
Merged
Ben Hillis (benhillis) merged 1 commit intoSep 22, 2026
Conversation
Copilot started reviewing on behalf of
Feng Wang (chemwolf6922)
September 22, 2026 04:25
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The bounds check prevents invalid pointer arithmetic and the added tests cover the new behavior.
Review effort: Lite
Findings: None
What changed in this PR
This PR hardens string-array pretty-printing against out-of-bounds message offsets and adds unit coverage.
Changes:
- Validate
StringArrayoffsets before constructing spans. - Test out-of-bounds and empty array cases.
| File | Description |
|---|---|
src/shared/inc/prettyprintshared.h |
Adds bounds-safe string-array printing. |
test/windows/UnitTests.cpp |
Covers invalid and empty offsets. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Blue (OneBlue)
approved these changes
Sep 22, 2026
Blue (OneBlue)
left a comment
Blue (OneBlue)
left a comment
Collaborator
There was a problem hiding this comment.
Good catch, thank you !
Ben Hillis (benhillis)
deleted the
user/chemwolf6922/prevent-potential-invalid-access-for-string-array-pretty-print
branch
September 22, 2026 21:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR follows the work in #41669 and adds length check for string arrays as well.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Update test:
UnitTests::UnitTests::PrettyPrintOutOfBoundsFields