Increase the VM termination timeout to 30 seconds - #41688
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Increases the VM graceful-termination timeout from 5 to 30 seconds to reduce shutdown failures under system pressure.
Changes:
- Extends the termination wait to 30 seconds.
- Updates the explanatory comment.
| File | Description |
|---|---|
src/windows/service/exe/HcsVirtualMachine.cpp |
Updates the VM termination timeout and comment. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Ben Hillis (benhillis)
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This change increases the VM termination timeout to 30 seconds, because we've seen test failures (specifically NamedVolumesVhdSessionRecovery) caused by the timeout being hit when the VM is under pressure, which causes the VM to terminate without flushing the pending operations, leading to test failures)
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed