dockerfile: update run mounts to stable channel#1717
Conversation
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
run-mount-stable
branch
from
a11a3ff to
906e345
Compare
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM, but left one question
| DOCKERFILE_RELEASES_CUSTOM="" | ||
| if [ "$TEST_DOCKERFILE" == 1 ]; then | ||
| if [ -z $DOCKERFILE_RELEASES ]; then | ||
| DOCKERFILE_RELEASES="mainline experimental mounts secrets ssh" |
There was a problem hiding this comment.
should we add mounts , secrets, and ssh as aliases for the stable image, so that dockerfiles that refer that syntax will get the current stable, and not some outdated version?
There was a problem hiding this comment.
Or perhaps also ignore the syntax for current versions as it would now be the default, so don't (try to ) pull the frontend?
There was a problem hiding this comment.
As long as DockerHub doesn't GC the latest mounts, secrets, and ssh images, I think it's fine? I think if secrets suddenly is supported on the mounts image that would be more confusing as an user.
There was a problem hiding this comment.
There is no mounts, secrets channel in dockerhub. Only daily builds that in dockerfile-upstream are timestamped already.
4 participants
fix #1675
@AkihiroSuda @hinshun @tiborvass @thaJeztah
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com