Do not require "experimental" for metrics API#40427
Merged
Merged
Conversation
Member
|
still draft? |
thaJeztah
force-pushed
the
prometheus_remove_experimental
branch
from
973dd3e to
07af276
Compare
Member
Author
|
Should probably be ok for review; rebased and moved out of "draft" |
Member
Author
|
ping @ehazlett PTAL; wdyt? |
Member
Author
|
(@ehazlett discussing with @tonistiigi to check if the metrics we have currently would conflict with metrics we could add in future, coming from containerd) |
cpuguy83
reviewed
Apr 16, 2020
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
prometheus_remove_experimental
branch
from
07af276 to
f337a8d
Compare
Member
Author
|
@cpuguy83 @tonistiigi updated; PTAL |
tiborvass
reviewed
May 8, 2020
| mux.Handle("/metrics", metrics.Handler()) | ||
| go func() { | ||
| http.Serve(l, mux) | ||
| logrus.Debugf("metrics API listening on %s", l.Addr()) |
Contributor
There was a problem hiding this comment.
I guess I don't understand why we have two places (here and in cmd/dockerd) where we start the metrics server.
tiborvass
approved these changes
May 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the requirement to enable experimental on the daemon to expose the prometheus metrics
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)