Conversation
The NodeSet CRD supports procMount (added in nebius#1980) and the operator renders it in the StatefulSet, but the nodesets Helm template does not pass it through. This prevents Helm-based deployments from setting procMount without manually patching the rendered CR.
There was a problem hiding this comment.
Pull request overview
Adds procMount passthrough support to the NodeSet Helm chart so users can set the container proc mount type via values, aligning the chart output with the CRD capabilities introduced in #1980.
Changes:
- Document
slurmd.security.procMountinhelm/nodesets/values.yaml. - Template optional
spec.slurmd.security.procMountinto the rendered NodeSet manifest.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| helm/nodesets/values.yaml | Documents the new procMount setting under nodesets[*].slurmd.security. |
| helm/nodesets/templates/nodeset.yaml | Conditionally renders spec.slurmd.security.procMount when provided in values. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| limitsConfig: "" | ||
| # Proc mount type for the slurmd container | ||
| # Optional, valid values: "Default", "Unmasked" | ||
| # procMount: "" |
There was a problem hiding this comment.
The new values.yaml example suggests procMount: "", but the CRD enum doesn’t allow an empty string (and in this chart it would also be treated as “unset” and omitted). Consider changing the commented example to a valid value (e.g. "Default" or "Unmasked") so users don’t copy an ineffective/invalid setting.
| # procMount: "" | |
| # procMount: "Default" |
| {{- with (get (.security | default dict) "procMount") }} | ||
| procMount: {{ . | quote }} | ||
| {{- end }} |
There was a problem hiding this comment.
This adds spec.slurmd.security.procMount, but the NodeSet CRD also supports spec.munge.security.procMount (same enum). If the intent is full “procMount passthrough” for NodeSets, consider templating it for the munge container as well (and documenting it in values.yaml), otherwise it’s unclear why only slurmd is supported.
Add procMount passthrough to nodesets Helm template. The CRD supports it (#1980) but the Helm template omits it.