Conversation
Uburro
force-pushed
the
uburro/rfc-024/0
branch
2 times, most recently
from
June 13, 2026 21:31
eaac297 to
7dfb95e
Compare
Uburro
marked this pull request as ready for review
June 14, 2026 10:09
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Soperator exposes only a curated subset of the K8s API for its generated resources (StatefulSet, DaemonSet, Service, ConfigMap…). Advanced users can't tweak them (annotations, tolerations, limits, hostNetwork) without requesting a new API field, forking, or fragile post-hoc patching that gets reverted on reconcile.
Solution
Adds the experimental ResourcePatchPolicy CRD (slurm.nebius.ai/v1alpha1) — a declarative escape hatch inspired by Envoy Gateway's EnvoyPatchPolicy.
JSON Patch (RFC 6902) and JSON Merge Patch (RFC 7386) applied in-memory to generated resources before submit, re-applied every reconcile.
targetRef for SlurmCluster | NodeSet | NodeConfigurator; selection by kind + exact name; priority ordering; protected-field guards (name/namespace/ownerReferences/selector).
Status controller reports an Accepted condition; opt-in via controllersEnabled.resourcepatchpolicy (off by default).
Testing
Engine unit tests, render-level tests against the real controller/worker/node-configurator resources, and controller tests (fake client). go build, go vet, make lint and affected tests pass. Verified manually on a cluster.
Release Notes
Feature: Added the experimental ResourcePatchPolicy CRD to patch operator-generated resources via JSON Patch / JSON Merge Patch, without forking. Opt-in (controllersEnabled.resourcepatchpolicy: true); permanently v1alpha1.