SCHED-1456: Fix vmagent remotewrite in umbrella chart - #2672
Merged
Merged
Conversation
asteny
approved these changes
Jul 1, 2026
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
vmagent received the Nebius o11y bearer token via a global
-remoteWrite.bearerTokenFilearg, which vmagent applies to every remote-write URL. This leaked the token to other endpoints and blocked adding extra customer remote-write destinations with their own auth.Solution
Use per-URL
bearerTokenSecretfor the o11y endpoint (secret kind) and an o11y-scoped positionalbearerTokenFile(hostPath kind), so extra destinations can carry their own auth. Replaced the in-pod IMDS sidecar with a standalonetsa-token-writer(bedagrawHelmRelease) that maintains theo11y-writer-sa-tokenSecret from IMDS or a host file.Testing
helm unittest117/117,helm lintclean, fullhelm templatefor both token kinds and writer sources.Release Notes
Feature: vmagent authenticates o11y remote-write via per-URL
bearerTokenSecret, allowing extra remote-write destinations with independent auth; token Secret maintained by the newtsa-token-writer. Breaking: removed the vmagent IMDS sidecar andtsaTokenSidecarvalues — usepublicEndpointTokenKind(secret/hostPath).