SCHED-1520, SCHED-1616: only fail acceptance for ActiveCheck errors - #2932
Merged
Conversation
ChessProfessor
changed the title
Uburro
approved these changes
Sep 4, 2026
ChessProfessor
deleted the
chessprofessor/SCHED-1520-SCHED-1616/remove-activechecks-readiness-assertion-4.0
branch
September 4, 2026 10:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SCHED-1520: The cluster-creation acceptance scenario requires every
runAfterCreationActiveCheck's mutable latest status to beComplete. A later scheduled run can legitimately change that status toInProgress, causing acceptance to fail even though Terraform already validated the initial run.SCHED-1616: The same assertion rejects the legitimate
Skippedstatus for an inapplicable ActiveCheck.Solution
Change the acceptance assertion to reject only actual failure states:
Failedfor Kubernetes jobs andFailedorErrorfor Slurm jobs.Allow transient and accepted states such as
InProgress,Skipped, andCancelled. Document beside the status predicate thatInProgressmay belong to a later scheduled execution because the ActiveChecks HelmRelease hook already gated the initial run.Apply the fix to release 4.0 and carry it through the merge-back chain to release 4.1 and main.