Skip to content

[stable34] fix(settings): display birthday correctly regardless of browsers timezone#61737

Open
backportbot[bot] wants to merge 2 commits into
stable34from
backport/61586/stable34
Open

[stable34] fix(settings): display birthday correctly regardless of browsers timezone#61737
backportbot[bot] wants to merge 2 commits into
stable34from
backport/61586/stable34

Conversation

@backportbot

@backportbot backportbot Bot commented Jul 3, 2026

Copy link
Copy Markdown

Backport of #61586

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Review and verify the backported changes
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

`savePrimaryAccountProperty` does only allow  `string | boolean`.
Incidentally, relying on `@nextcloud/axios` default serialization, `Date`s where serialized using `toISOString`.
See https://github.com/axios/axios/blob/a7d7a714498452e611943d9d8e5c2ed8b00aa6b9/lib/helpers/toFormData.js#L134

This change corrects the usage of `savePrimaryAccountProperty` and makes serialization explicit.

Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
@backportbot backportbot Bot requested review from odzhychko, skjnldsv and susnux July 3, 2026 06:44
@backportbot backportbot Bot added bug 3. to review Waiting for reviews labels Jul 3, 2026
@backportbot backportbot Bot added this to the Nextcloud 34.0.2 milestone Jul 3, 2026
…zone

fix(settings): display birthday correctly regardless of browsers timezone

This also avoid shifting dates after user input.

Resolves #49828

Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
@odzhychko odzhychko force-pushed the backport/61586/stable34 branch from cf8c233 to b9de75e Compare July 3, 2026 07:27
@odzhychko odzhychko marked this pull request as ready for review July 3, 2026 07:28
@odzhychko odzhychko requested a review from a team as a code owner July 3, 2026 07:28
@odzhychko odzhychko requested review from sorbaugh and removed request for a team July 3, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

1 participant