chore(analyzer): Allow dry-running without an output directory

[sschuberth]

No description provided.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.21%. Comparing base (fce14c4) to head (d4372f6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #12444   +/-   ##
=========================================
  Coverage     59.21%   59.21%           
  Complexity     1892     1892           
=========================================
  Files           366      366           
  Lines         13839    13839           
  Branches       1462     1462           
=========================================
  Hits           8195     8195           
  Misses         5114     5114           
  Partials        530      530           

Flag	Coverage Δ
funTest-external-tools	16.13% <ø> (ø)
test-ubuntu-26.04	42.61% <ø> (ø)
test-windows-2025	42.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Addressed.

[lamppu]

I'm getting this error for the downloader dry run:

Exception in thread "main" java.lang.IllegalArgumentException: The output directory '/tmp' must not contain any files yet.
	at org.ossreviewtoolkit.downloader.Downloader.verifyOutputDirectory(Downloader.kt:60)
	at org.ossreviewtoolkit.downloader.Downloader.download(Downloader.kt:73)
	at org.ossreviewtoolkit.plugins.commands.downloader.DownloadCommand.downloadPackage(DownloadCommand.kt:431)
	at org.ossreviewtoolkit.plugins.commands.downloader.DownloadCommand.access$downloadPackage(DownloadCommand.kt:109)
	at org.ossreviewtoolkit.plugins.commands.downloader.DownloadCommand$downloadPackages$1$2$1$1.invokeSuspend(DownloadCommand.kt:416)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:34)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:100)
	at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.kt:124)
	at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:89)
	at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:586)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:798)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:717)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:704)
	Suppressed: java.lang.IllegalArgumentException: The output directory '/tmp' must not contain any files yet.
		... 13 more

[sschuberth]

Thanks for checking! I've addressed this in a new commit.

[lamppu]

There's now some weird behavior, for example when there's a download failure like:

VCS download failed for 'NPM::mime-db:1.33.0': DownloadException: Unhandled VCS URL https://github.com/jshttp/mime-db.git.

that triggers a cleanup for the tmp folder, which deletes all files in the folder, and I guess if I'm reading it correctly it tries to remove the tmp folder itself and for me it fails there because it doesn't have sufficient permissions.

So idk, should the outputDirectory.safeDeleteRecursively(baseDirectory = outputDirectory) calls maybe be ignored for the dry run or something?

Here's the exception:

Exception in thread "main" java.nio.file.FileSystemException: Failed to delete one or more files. See suppressed exceptions for details.
	at kotlin.io.path.PathsKt__PathRecursiveFunctionsKt.deleteRecursively(PathRecursiveFunctions.kt:368)
	at org.ossreviewtoolkit.utils.common.FileUtilsKt.safeDeleteRecursively(FileUtils.kt:126)
	at org.ossreviewtoolkit.downloader.Downloader.handleVcsDownload(Downloader.kt:123)
	at org.ossreviewtoolkit.downloader.Downloader.download(Downloader.kt:72)
	at org.ossreviewtoolkit.plugins.commands.downloader.DownloadCommand.downloadPackage(DownloadCommand.kt:432)
	at org.ossreviewtoolkit.plugins.commands.downloader.DownloadCommand.access$downloadPackage(DownloadCommand.kt:109)
	at org.ossreviewtoolkit.plugins.commands.downloader.DownloadCommand$downloadPackages$1$2$1$1.invokeSuspend(DownloadCommand.kt:416)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:34)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:100)
	at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.kt:124)
	at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:89)
	at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:586)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:798)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:717)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:704)
	Suppressed: java.nio.file.FileSystemException: /tmp
		at kotlin.io.path.ExceptionsCollector.collect(PathRecursiveFunctions.kt:398)
		at kotlin.io.path.PathsKt__PathRecursiveFunctionsKt.handleEntry$PathsKt__PathRecursiveFunctionsKt(PathRecursiveFunctions.kt:596)
		at kotlin.io.path.PathsKt__PathRecursiveFunctionsKt.deleteRecursivelyImpl$PathsKt__PathRecursiveFunctionsKt(PathRecursiveFunctions.kt:420)
		at kotlin.io.path.PathsKt__PathRecursiveFunctionsKt.deleteRecursively(PathRecursiveFunctions.kt:365)
		... 14 more
	Caused by: java.nio.file.AccessDeniedException: tmp
		at java.base/sun.nio.fs.UnixException.translateToIOException(UnixException.java:90)
		at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:106)
		at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:111)
		at java.base/sun.nio.fs.UnixSecureDirectoryStream.implDelete(UnixSecureDirectoryStream.java:179)
		at java.base/sun.nio.fs.UnixSecureDirectoryStream.deleteDirectory(UnixSecureDirectoryStream.java:193)
		at java.base/sun.nio.fs.UnixSecureDirectoryStream.deleteDirectory(UnixSecureDirectoryStream.java:42)