Skip to content

Post-merge review for light-dark - #2506

Merged
drammock merged 1 commit into
mainfrom
review2
Sep 25, 2026
Merged

Post-merge review for light-dark#2506
drammock merged 1 commit into
mainfrom
review2

Conversation

@Yann-P

@Yann-P Yann-P commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator
@Yann-P

Yann-P commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator Author

@flying-sheep to follow up your comments.
@github-actions

github-actions Bot commented Sep 25, 2026

Copy link
Copy Markdown

Coverage report

This PR does not seem to contain any modification to coverable code.
@flying-sheep

flying-sheep commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

That’s all I had.

The PR added this:

The theme defines its colors on html[data-theme="light"] and html[data-theme="dark"], which are more specific than :root, so a :root rule would be ignored.

which makes me think that we could use CSS layers so people aren’t trapped in a specificity hell, but that’s a separate concern.
@Yann-P

Yann-P commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator Author

ok, feel free to open an issue on css layers
@drammock
drammock merged commit 46a8149 into main Sep 25, 2026
32 of 33 checks passed
@drammock
drammock deleted the review2 branch September 25, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@Yann-P @flying-sheep @drammock