fix: wrap unresolvable $ref in ValidationError#519
Open
patchwright wants to merge 1 commit into
Open
Conversation
When a $ref points to a nonexistent target, the referencing library's Unresolvable (PointerToNowhere) exception escaped uncaught instead of being wrapped in a ValidationError. This leaked the internal library exception (and, as a side effect, dumped the entire spec into the error message). Catch Unresolvable in SpecValidator.validate() and is_valid(), wrap in jsonschema.exceptions.ValidationError. Updated existing test_ref_failed tests to expect ValidationError (the documented behavior) instead of Unresolvable (the leak). Fixes python-openapi#511. Assisted-by: Claude (Anthropic). Co-Authored-By: claude-flow <ruv@ruv.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a
$refpoints to a nonexistent target,referencing.exceptions.Unresolvable(PointerToNowhere) escapes uncaught instead of being wrapped in aValidationError. The internal library exception leaks to the caller, and as a side effect dumps the entire spec into the error message.Reproduction (from #511)
Cause
The
Unresolvableexception escapes duringiter_errors()generation (when a$refis resolved), so thewraps_errorsdecorator — which only wraps yielded errors — doesn't catch it.Fix
Catch
referencing.exceptions.UnresolvableinSpecValidator.validate()andSpecValidator.is_valid():validate(): wrap injsonschema.exceptions.ValidationErroris_valid(): returnFalse(the spec is invalid)Test
Updated the existing
test_ref_failedtests (v2 + v3.1 parametrized) to expectValidationError(the documented behavior) instead ofUnresolvable(the leak). 45/45 integration tests pass.Fixes #511.
Assisted-by: Claude (Anthropic).